Chore: handle search input validation in RunE

Author: rkpattnaik780

cmd/rhoas/pkged.go

@@ -14,7 +14,7 @@ one = 'Kafka instance name must be between 1 and 32 characters'
 [kafka.validation.error.invalidSearchValue]
 description = 'Error message when invalid search input is provided'
 one = '''
-Illegal search value "{{.Search}}", search input must satisfy the following conditions:
+illegal search value "{{.Search}}", search input must satisfy the following conditions:
 
   - must be of 1 or more characters
   - must only consist of alphanumeric characters, '-', '_' and '%'

locales/kafka/active.en.toml

@@ -68,6 +68,9 @@ func NewListCommand(f *factory.Factory) *cobra.Command {
 			if opts.outputFormat != "" && !flagutil.IsValidInput(opts.outputFormat, flagutil.ValidOutputFormats...) {
 				return flag.InvalidValueError("output", opts.outputFormat, flagutil.ValidOutputFormats...)
 			}
+			if err := kafka.ValidateSearchInput(opts.search); err != nil {
+				return err
+			}
 
 			return runList(opts)
 		},
@@ -103,10 +106,6 @@ func runList(opts *options) error {
 
 	if opts.search != "" {
 
-		if err = kafka.ValidateSearchInput(opts.search); err != nil {
-			return err
-		}
-
 		logger.Debug(localizer.MustLocalize(&localizer.Config{
 			MessageID: "kafka.list.log.debug.filteringKafkaList",
 			TemplateData: map[string]interface{}{

pkg/cmd/kafka/list/list.go

@@ -71,6 +71,7 @@ func TransformKafkaRequest(kafka *kasclient.KafkaRequest) *kasclient.KafkaReques
 	return kafka
 }
 
+// ValidateSearchInput validates the text provided to filter the Kafka instances
 func ValidateSearchInput(val interface{}) error {
 	search, ok := val.(string)