fix(serviceaccount reset-credentials): validate serviceaccount ID in prompt (#720)

Author: rkpattnaik780

pkg/cmd/serviceaccount/resetcredentials/reset_credentials.go

@@ -15,6 +15,7 @@ import (
 	flagutil "github.com/redhat-developer/app-services-cli/pkg/cmdutil/flags"
 	"github.com/redhat-developer/app-services-cli/pkg/iostreams"
 	"github.com/redhat-developer/app-services-cli/pkg/serviceaccount/credentials"
+	"github.com/redhat-developer/app-services-cli/pkg/serviceaccount/validation"
 
 	"github.com/redhat-developer/app-services-cli/internal/config"
 	"github.com/redhat-developer/app-services-cli/pkg/cmd/factory"
@@ -70,6 +71,11 @@ func NewResetCredentialsCommand(f *factory.Factory) *cobra.Command {
 				return flag.InvalidValueError("file-format", opts.fileFormat, flagutil.CredentialsOutputFormats...)
 			}
 
+			validID := validation.ValidateUUID(opts.localizer)(opts.id)
+			if validID != nil {
+				return validID
+			}
+
 			return runResetCredentials(opts)
 		},
 	}
@@ -217,7 +223,7 @@ func runInteractivePrompt(opts *Options) (err error) {
 		Help:    opts.localizer.MustLocalize("serviceAccount.resetCredentials.input.id.help"),
 	}
 
-	err = survey.AskOne(promptID, &opts.id, survey.WithValidator(survey.Required))
+	err = survey.AskOne(promptID, &opts.id, survey.WithValidator(survey.Required), survey.WithValidator(validation.ValidateUUID(opts.localizer)))
 	if err != nil {
 		return err
 	}

pkg/localize/locales/en/cmd/serviceaccount.en.toml

@@ -86,4 +86,7 @@ one = 'invalid service account name "{{.Name}}"; only lowercase letters (a-z), n
 one = 'invalid service account description: only alphanumeric characters and "-", ".", "," are accepted.'
 
 [serviceAccount.common.validation.description.error.lengthError]
-one = 'service account description cannot exceed {{.MaxLen}} characters'
+one = 'service account description cannot exceed {{.MaxLen}} characters'
+
+[serviceAccount.common.validation.id.error.invalidID]
+one = '"{{.ID}}" is not a valid UUID'

pkg/serviceaccount/validation/validation.go

@@ -6,13 +6,15 @@ import (
 	"regexp"
 
 	"github.com/redhat-developer/app-services-cli/pkg/common/commonerr"
+	"github.com/redhat-developer/app-services-cli/pkg/localize"
 )
 
 const (
 	// name validation rules
 	legalNameChars = "^[a-z]([-a-z0-9]*[a-z0-9])?$"
 	maxNameLength  = 50
 	minNameLength  = 1
+	legalUUID      = "^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$"
 	// description validation rules
 	legalDescriptionChars = "^[a-zA-Z0-9.,\\-\\s]*$"
 	maxDescriptionLength  = 255
@@ -63,3 +65,22 @@ func ValidateDescription(val interface{}) error {
 
 	return errors.New(`invalid service account description; only alphanumeric characters and "-", ".", "," are accepted`)
 }
+
+// ValidateUUID validates if ID is a valid UUID
+func ValidateUUID(localizer localize.Localizer) func(v interface{}) error {
+	return func(val interface{}) error {
+		id, ok := val.(string)
+		if !ok {
+			return commonerr.NewCastError(val, "string")
+		}
+
+		matched, _ := regexp.Match(legalUUID, []byte(id))
+
+		if matched {
+			return nil
+		}
+
+		return errors.New(localizer.MustLocalize("serviceAccount.common.validation.id.error.invalidID", localize.NewEntry("ID", id)))
+	}
+
+}

pkg/serviceaccount/validation/validation_test.go

@@ -2,6 +2,8 @@ package validation
 
 import (
 	"testing"
+
+	"github.com/redhat-developer/app-services-cli/pkg/localize/goi18n"
 )
 
 func TestValidateName(t *testing.T) {
@@ -69,6 +71,58 @@ func TestValidateName(t *testing.T) {
 	}
 }
 
+func TestValidateUUID(t *testing.T) {
+	type args struct {
+		val interface{}
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantErr bool
+	}{
+		{
+			name:    "fails when length is 5",
+			args:    args{"kafka"},
+			wantErr: true,
+		},
+		{
+			name:    "fails for empty string",
+			args:    args{""},
+			wantErr: true,
+		},
+		{
+			name:    "fails for special chars",
+			args:    args{"9e4d1b1f-19d*-47c2-a334-e420c5e5bbce"},
+			wantErr: true,
+		},
+		{
+			name:    "passes for valid UUID",
+			args:    args{"9e4d1b1f-19dd-47c2-a334-e420c5e5bbce"},
+			wantErr: false,
+		},
+		{
+			name:    "passes for numeric UUID",
+			args:    args{"11111111-2222-3333-4444-555555555555"},
+			wantErr: false,
+		},
+		{
+			name:    "fails for ID containing capital letters",
+			args:    args{"9e4d1b1f-19dd-47c2-A334-e420c5e5bbce"},
+			wantErr: true,
+		},
+	}
+
+	localizer, _ := goi18n.New(nil)
+	// nolint:scopelint
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if err := ValidateUUID(localizer)(tt.args.val); (err != nil) != tt.wantErr {
+				t.Errorf("ValidateUUID() error = %v, wantErr %v", err, tt.wantErr)
+			}
+		})
+	}
+}
+
 func TestValidateDescription(t *testing.T) {
 	type args struct {
 		val interface{}