Skip to content

Commit 90c311b

Browse files
Vineeth Remanan Pillaidavem330
authored andcommitted
xen-netfront: Fix Rx stall during network stress and OOM
During an OOM scenario, request slots could not be created as skb allocation fails. So the netback cannot pass in packets and netfront wrongly assumes that there is no more work to be done and it disables polling. This causes Rx to stall. The issue is with the retry logic which schedules the timer if the created slots are less than NET_RX_SLOTS_MIN. The count of new request slots to be pushed are calculated as a difference between new req_prod and rsp_cons which could be more than the actual slots, if there are unconsumed responses. The fix is to calculate the count of newly created slots as the difference between new req_prod and old req_prod. Signed-off-by: Vineeth Remanan Pillai <[email protected]> Reviewed-by: Juergen Gross <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent e048fc5 commit 90c311b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/xen-netfront.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ static void xennet_alloc_rx_buffers(struct netfront_queue *queue)
321321
queue->rx.req_prod_pvt = req_prod;
322322

323323
/* Not enough requests? Try again later. */
324-
if (req_prod - queue->rx.rsp_cons < NET_RX_SLOTS_MIN) {
324+
if (req_prod - queue->rx.sring->req_prod < NET_RX_SLOTS_MIN) {
325325
mod_timer(&queue->rx_refill_timer, jiffies + (HZ/10));
326326
return;
327327
}

0 commit comments

Comments
 (0)