Skip to content

Commit 7dede91

Browse files
Li Zhongherbertx
authored andcommitted
crypto: vmx - disable preemption to enable vsx in aes_ctr.c
Some preemptible check warnings were reported from enable_kernel_vsx(). This patch disables preemption in aes_ctr.c before enabling vsx, and they are now consistent with other files in the same directory. Signed-off-by: Li Zhong <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent d03f7b0 commit 7dede91

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/crypto/vmx/aes_ctr.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,13 @@ static int p8_aes_ctr_setkey(struct crypto_tfm *tfm, const u8 *key,
8080
int ret;
8181
struct p8_aes_ctr_ctx *ctx = crypto_tfm_ctx(tfm);
8282

83+
preempt_disable();
8384
pagefault_disable();
8485
enable_kernel_vsx();
8586
ret = aes_p8_set_encrypt_key(key, keylen * 8, &ctx->enc_key);
8687
disable_kernel_vsx();
8788
pagefault_enable();
89+
preempt_enable();
8890

8991
ret += crypto_blkcipher_setkey(ctx->fallback, key, keylen);
9092
return ret;
@@ -99,11 +101,13 @@ static void p8_aes_ctr_final(struct p8_aes_ctr_ctx *ctx,
99101
u8 *dst = walk->dst.virt.addr;
100102
unsigned int nbytes = walk->nbytes;
101103

104+
preempt_disable();
102105
pagefault_disable();
103106
enable_kernel_vsx();
104107
aes_p8_encrypt(ctrblk, keystream, &ctx->enc_key);
105108
disable_kernel_vsx();
106109
pagefault_enable();
110+
preempt_enable();
107111

108112
crypto_xor(keystream, src, nbytes);
109113
memcpy(dst, keystream, nbytes);
@@ -132,6 +136,7 @@ static int p8_aes_ctr_crypt(struct blkcipher_desc *desc,
132136
blkcipher_walk_init(&walk, dst, src, nbytes);
133137
ret = blkcipher_walk_virt_block(desc, &walk, AES_BLOCK_SIZE);
134138
while ((nbytes = walk.nbytes) >= AES_BLOCK_SIZE) {
139+
preempt_disable();
135140
pagefault_disable();
136141
enable_kernel_vsx();
137142
aes_p8_ctr32_encrypt_blocks(walk.src.virt.addr,
@@ -143,6 +148,7 @@ static int p8_aes_ctr_crypt(struct blkcipher_desc *desc,
143148
walk.iv);
144149
disable_kernel_vsx();
145150
pagefault_enable();
151+
preempt_enable();
146152

147153
/* We need to update IV mostly for last bytes/round */
148154
inc = (nbytes & AES_BLOCK_MASK) / AES_BLOCK_SIZE;

0 commit comments

Comments
 (0)