add foxy packages for rosbag2, dummy reader/writer #14461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Nir-Az
reviewed
Nov 19, 2025
src/media/ros2/ros2_reader.cpp
Outdated
| @@ -0,0 +1,161 @@ | |||
| // License: Apache 2.0. See LICENSE file in root directory. | |||
Collaborator
There was a problem hiding this comment.
Why not full realsense copyrights like on other files?
Nir-Az
reviewed
Nov 19, 2025
| project(rosbag2_independent) | ||
|
|
||
| # Allow consumers to opt-in explicitly; default OFF to avoid configuration failures | ||
| option(BUILD_ROSBAG2 "Build rosbag2 third-party components" OFF) |
Collaborator
There was a problem hiding this comment.
We keep options in cmake/lrs_options.cmake
Nir-Az
reviewed
Nov 19, 2025
| FetchContent_Declare( | ||
| yaml-cpp | ||
| GIT_REPOSITORY https://github.com/jbeder/yaml-cpp.git | ||
| GIT_TAG master # using master for latest version, we can also pick a specific commit but we need one after version 0.8.0 - we need YAML_CPP_DISABLE_UNINSTALL flag |
Collaborator
There was a problem hiding this comment.
We always choose a specific commit / release so our code will not break.
Please also explane is a comment the need for this package.
Contributor
Author
|
This reverts commit 72dfb04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on: [LRS-1243]