-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Expand file tree
/
Copy pathUnusedClosureParameterRule.swift
More file actions
137 lines (123 loc) · 5.45 KB
/
Copy pathUnusedClosureParameterRule.swift
File metadata and controls
137 lines (123 loc) · 5.45 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
@preconcurrency import SwiftSyntax
import SwiftSyntaxBuilder
@SwiftSyntaxRule(explicitRewriter: true)
struct UnusedClosureParameterRule: Rule {
var configuration = SeverityConfiguration<Self>(.warning)
static let description = RuleDescription(
identifier: "unused_closure_parameter",
name: "Unused Closure Parameter",
description: "Unused parameter in a closure should be replaced with _",
kind: .lint,
nonTriggeringExamples: UnusedClosureParameterRuleExamples.nonTriggering,
triggeringExamples: UnusedClosureParameterRuleExamples.triggering,
corrections: UnusedClosureParameterRuleExamples.corrections
)
}
private extension UnusedClosureParameterRule {
final class Visitor: ViolationsSyntaxVisitor<ConfigurationType> {
override func visitPost(_ node: ClosureExprSyntax) {
let namedParameters = node.namedParameters
guard namedParameters.isNotEmpty else {
return
}
let referencedIdentifiers = IdentifierReferenceVisitor(viewMode: .sourceAccurate)
.walk(tree: node.statements, handler: \.identifiers)
for parameter in namedParameters where !referencedIdentifiers.contains(parameter.name) {
violations.append(parameter.position)
}
}
}
final class Rewriter: ViolationsSyntaxRewriter {
override func visit(_ node: ClosureExprSyntax) -> ExprSyntax {
guard node.namedParameters.isNotEmpty,
let signature = node.signature,
let input = signature.parameterClause else {
return super.visit(node)
}
let referencedIdentifiers = IdentifierReferenceVisitor(viewMode: .sourceAccurate)
.walk(tree: node.statements, handler: \.identifiers)
guard let params = input.as(ClosureShorthandParameterListSyntax.self) else {
guard let params = input.as(ClosureParameterClauseSyntax.self) else {
return super.visit(node)
}
var newParams = params
for param in params.parameters {
let name = param.firstName
guard name.tokenKind != .wildcard,
!referencedIdentifiers.contains(name.text.removingDollarsAndBackticks),
let index = params.parameters.index(of: param) else {
continue
}
correctionPositions.append(name.positionAfterSkippingLeadingTrivia)
let newParameterList = newParams.parameters.with(
\.[index],
param.with(\.firstName, name.with(\.tokenKind, .wildcard))
)
newParams = newParams.with(\.parameters, newParameterList)
}
let newNode = node.with(\.signature, signature.with(\.parameterClause, .init(newParams)))
return super.visit(newNode)
}
var newParams = params
for param in params {
guard param.name.tokenKind != .wildcard,
!referencedIdentifiers.contains(param.name.text.removingDollarsAndBackticks),
let index = params.index(of: param) else {
continue
}
correctionPositions.append(param.name.positionAfterSkippingLeadingTrivia)
newParams = newParams.with(
\.[index],
param.with(\.name, param.name.with(\.tokenKind, .wildcard))
)
}
let newNode = node.with(\.signature, signature.with(\.parameterClause, .init(newParams)))
return super.visit(newNode)
}
}
}
private final class IdentifierReferenceVisitor: SyntaxVisitor {
private(set) var identifiers: Set<String> = []
override func visitPost(_ node: DeclReferenceExprSyntax) {
if node.keyPathInParent != \MemberAccessExprSyntax.declName {
identifiers.insert(node.baseName.text.removingDollarsAndBackticks)
}
}
}
private extension String {
var removingDollarsAndBackticks: String {
self.replacingOccurrences(of: "$", with: "")
.replacingOccurrences(of: "`", with: "")
}
}
private struct ClosureParam {
let position: AbsolutePosition
let name: String
}
private extension ClosureExprSyntax {
var namedParameters: [ClosureParam] {
if let params = signature?.parameterClause?.as(ClosureShorthandParameterListSyntax.self) {
return params.compactMap { param in
if param.name.tokenKind == .wildcard {
return nil
}
return ClosureParam(
position: param.name.positionAfterSkippingLeadingTrivia,
name: param.name.text.removingDollarsAndBackticks
)
}
} else if let params = signature?.parameterClause?.as(ClosureParameterClauseSyntax.self)?.parameters {
return params.compactMap { param in
if param.firstName.tokenKind == .wildcard {
return nil
}
return ClosureParam(
position: param.firstName.positionAfterSkippingLeadingTrivia,
name: param.firstName.text.removingDollarsAndBackticks
)
}
} else {
return []
}
}
}