Fix stress test expectation and bug in ColdTestPublisher
#3700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
chemicL
approved these changes
Jan 23, 2024
chemicL
added
type/test
chemicL
reviewed
Jan 30, 2024
Comment on lines
273
to
274
| // Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3633) | ||
| //@JCStressTest |
Member
There was a problem hiding this comment.
Suggested change
| // Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3633) | |
| //@JCStressTest | |
| @JCStressTest |
Member
There was a problem hiding this comment.
This and the other tests can now have the ignores removed
chemicL
requested changes
Jan 30, 2024
Member
chemicL
left a comment
chemicL
left a comment
There was a problem hiding this comment.
I realized that the tests are effectively disabled at the moment. As this PR aims to fix the flakiness, these tests can be re-enabled.
chemicL
approved these changes
Feb 13, 2024
|
@chemicL this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
chemicL
added a commit
that referenced
this pull request
Feb 13, 2024
Member
|
The related tests can be uncommented as a follow-up. |
chemicL
added a commit
that referenced
this pull request
Feb 13, 2024
violetagg
changed the title
ColdTestPublisher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an early termination bug in
ColdTestPublisherwhich happens when request from the downstream subscriber races with new values and following termination which in rare case endups in termination without propagation of the remaining values. Also this PR improves expectation for the stress test where ColdTestPulisher takes a key rolecloses #3633