feat(TestScheduler): Add subscription schedule to expectObservable#3997
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Aug 20, 2018
Merged
feat(TestScheduler): Add subscription schedule to expectObservable#3997benlesh merged 1 commit intoReactiveX:masterfrom
benlesh merged 1 commit intoReactiveX:masterfrom
Conversation
Member
|
Could you please describe the use cases and motivation for the change? This isn't anything that has been considered or discussed on the team, so my immediate concern is that there isn't a need for it. Giving us concrete examples of where it's a useful feature will help us decide what we should do here. |
Contributor
Author
|
An example use would be to test shareReplay. would be rewritten to something like this |
Member
|
@gstamac That's a great example! I'll add this to our core team agenda so we can discuss it. Thanks! |
Member
|
#4006 fixes the travis issue. |
cartant
approved these changes
Aug 16, 2018
Member
|
Thanks, @gstamac! Good addition! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I made this PR (#3429) already for the previous version but was rejected because of API changes. Now the new API is here and I'm making the same PR.
Related issue (if exists): #3429