fix(IE10): Remove dependency on Object.setPrototypeOf#3967
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Jul 28, 2018
Merged
fix(IE10): Remove dependency on Object.setPrototypeOf#3967benlesh merged 1 commit intoReactiveX:masterfrom
benlesh merged 1 commit intoReactiveX:masterfrom
Conversation
This reimplements all Error types as ES5 classes, and types them with TypeScript such that we no longer need to rely on Object.setPrototypeOf, which was causing issues for users who had not polyfilled it properly in IE10. fixes ReactiveX#3966
|
Has this been released already? I can still see setPrototypeOf in 6.2.2 |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reimplements all Error types as ES5 classes, and types them with TypeScript such that
we no longer need to rely on Object.setPrototypeOf, which was causing issues for users who had not
polyfilled it properly in IE10.
fixes #3966