fix(AjaxObservable): notify with error if fails to parse json response#3139
Merged
benlesh merged 2 commits intoReactiveX:masterfrom Jul 26, 2018
Merged
fix(AjaxObservable): notify with error if fails to parse json response#3139benlesh merged 2 commits intoReactiveX:masterfrom
benlesh merged 2 commits intoReactiveX:masterfrom
Conversation
Contributor
|
Any updates on this? |
Member
|
Given this PR is massively in conflict, I'm not sure it can be merged. But I think the work here is important. Labelling it for refactor. |
Catch error when parsing json response and notify observer with thrown error. JSON could be invalid if proxy overtakes the response and in IE responseType is empty. closes ReactiveX#3138
Collaborator
|
@benlesh I've rebased and refactored this PR. |
benlesh
approved these changes
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch error when parsing json response and notify observer with thrown error.
JSON could be invalid if proxy overtakes the response and in IE responseType is empty.
closes #3138
Description:
Please find description under the issue. This is my first PR to rxjs, so any feedback is welcome.
Related issue (if exists): #3138