Skip to content

Commit 7d16f20

Browse files
glennawatsonRLittlesII
authored andcommitted
fix: uno not including ReactiveUI NuGet package (#2091)
1 parent 121458e commit 7d16f20

14 files changed

+64
-31
lines changed

src/ReactiveUI.Uno/ActivationForViewFetcher.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
using Windows.Foundation;
1313
using Windows.UI.Xaml;
1414

15-
namespace ReactiveUI
15+
namespace ReactiveUI.Uno
1616
{
1717
/// <summary>
1818
/// ActiveationForViewFetcher is how ReactiveUI determine when a

src/ReactiveUI.Uno/PlatformRegistrations.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
using System.Reactive.Concurrency;
88
using System.Reactive.PlatformServices;
99

10-
namespace ReactiveUI
10+
namespace ReactiveUI.Uno
1111
{
1212
/// <summary>
1313
/// UWP platform registrations.
@@ -23,7 +23,9 @@ public void Register(Action<Func<object>, Type> registerFunction)
2323
registerFunction(() => new DependencyObjectObservableForProperty(), typeof(ICreatesObservableForProperty));
2424
registerFunction(() => new BooleanToVisibilityTypeConverter(), typeof(IBindingTypeConverter));
2525
registerFunction(() => new AutoDataTemplateBindingHook(), typeof(IPropertyBindingHook));
26-
registerFunction(() => new WinRTAppDataDriver(), typeof(ISuspensionDriver));
26+
27+
// Re-enable once the obsolete code in Uno has been worked out.
28+
////registerFunction(() => new WinRTAppDataDriver(), typeof(ISuspensionDriver));
2729

2830
#if NETSTANDARD
2931
if (WasmPlatformEnlightenmentProvider.IsWasm)

src/ReactiveUI.Uno/ReactiveUI.Uno.csproj

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,10 @@
1212
</PropertyGroup>
1313

1414
<ItemGroup>
15-
<PackageReference Include="Uno.UI" Version="1.44.1" />
16-
<PackageReference Include="System.Reactive" Version="4.1.5" />
17-
<PackageReference Include="Splat" Version="7.*" />
18-
<PackageReference Include="DynamicData" Version="6.*" />
15+
<PackageReference Include="Uno.UI" Version="1.*" />
1916
</ItemGroup>
2017

2118
<ItemGroup>
22-
<!-- Include all the files under RxUI, due to the way Uno works we need to duplicate -->
23-
<Compile Include="..\ReactiveUI\**\*.cs" LinkBase="ReactiveUI" />
24-
25-
<Compile Remove="..\ReactiveUI\Platforms\**\*.*" />
26-
<Compile Remove="..\ReactiveUI\**\bin\**\*.*" />
27-
<Compile Remove="..\ReactiveUI\**\obj\**\*.*" />
28-
29-
<Compile Remove=".\Platforms\**\*.*" />
30-
3119
<Compile Include="..\ReactiveUI\Platforms\uap\TransitioningContentControl.Empty.cs" LinkBase="ReactiveUI\Platforms\uap" />
3220
<Compile Include="..\ReactiveUI\Platforms\uap\DependencyObjectObservableForProperty.cs" LinkBase="ReactiveUI\Platforms\uap" />
3321
<Compile Include="..\ReactiveUI\Platforms\windows-common\**\*.cs" LinkBase="ReactiveUI\Platforms\windows-common" />
@@ -40,4 +28,7 @@
4028
<Compile Include=".\Platforms\netstandard\**\*.cs" />
4129
</ItemGroup>
4230

31+
<ItemGroup>
32+
<ProjectReference Include="..\ReactiveUI\ReactiveUI.csproj" />
33+
</ItemGroup>
4334
</Project>

src/ReactiveUI.Uno/WinRTAppDataDriver.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
using Windows.Storage;
1919
using UnicodeEncoding = Windows.Storage.Streams.UnicodeEncoding;
2020

21-
namespace ReactiveUI
21+
namespace ReactiveUI.Uno
2222
{
2323
/// <summary>
2424
/// Loads and saves state to persistent storage.

src/ReactiveUI/Platforms/uap/DependencyObjectObservableForProperty.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,11 @@
1313
using Splat;
1414
using Windows.UI.Xaml;
1515

16+
#if HAS_UNO
17+
namespace ReactiveUI.Uno
18+
#else
1619
namespace ReactiveUI
20+
#endif
1721
{
1822
/// <summary>
1923
/// Creates a observable for a property if available that is based on a DependencyProperty.

src/ReactiveUI/Platforms/uap/TransitioningContentControl.Empty.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66
using System.Diagnostics.CodeAnalysis;
77
using Windows.UI.Xaml.Controls;
88

9+
#if HAS_UNO
10+
namespace ReactiveUI.Uno
11+
#else
912
namespace ReactiveUI
13+
#endif
1014
{
1115
/// <summary>
1216
/// A control with a single transition.

src/ReactiveUI/Platforms/windows-common/AutoDataTemplateBindingHook.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@
1616
using System.Windows.Markup;
1717
#endif
1818

19+
#if HAS_UNO
20+
namespace ReactiveUI.Uno
21+
#else
1922
namespace ReactiveUI
23+
#endif
2024
{
2125
/// <summary>
2226
/// AutoDataTemplateBindingHook is a binding hook that checks ItemsControls

src/ReactiveUI/Platforms/windows-common/BooleanToVisibilityHint.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@
1111
using System.Windows;
1212
#endif
1313

14+
#if HAS_UNO
15+
namespace ReactiveUI.Uno
16+
#else
1417
namespace ReactiveUI
18+
#endif
1519
{
1620
/// <summary>
1721
/// Enum that hints at the visibility of a ui element.

src/ReactiveUI/Platforms/windows-common/BooleanToVisibilityTypeConverter.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@
1010
using System.Windows;
1111
#endif
1212

13+
#if HAS_UNO
14+
namespace ReactiveUI.Uno
15+
#else
1316
namespace ReactiveUI
17+
#endif
1418
{
1519
/// <summary>
1620
/// This type convert converts between Boolean and XAML Visibility - the

src/ReactiveUI/Platforms/windows-common/PlatformOperations.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@
99
using System.Text;
1010
using System.Threading.Tasks;
1111

12+
#if HAS_UNO
13+
namespace ReactiveUI.Uno
14+
#else
1215
namespace ReactiveUI
16+
#endif
1317
{
1418
/// <summary>
1519
/// Returns the current orientation of the device on Windows.

0 commit comments

Comments
 (0)