Skip to content

Commit 5c7823f

Browse files
cipolleschifabriziocucci
authored andcommitted
Properly test JSC for template_app e2e tests (#48656)
Summary: Pull Request resolved: #48656 While working on 0.78, I realize we were not testing the template app with JSC. This change should fix this. ## Changelog: [Internal] - Disable Hermes for the JSC E2E tests with Maestro Reviewed By: cortinico, fabriziocucci Differential Revision: D68147849 fbshipit-source-id: 4fbe005b5d04d6163a37041d1bd57fd48a9dfda8
1 parent b713f27 commit 5c7823f

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

.github/workflows/test-all.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,11 @@ jobs:
369369
sed -i 's/newArchEnabled=true/newArchEnabled=false/' android/gradle.properties
370370
fi
371371
372+
if [[ ${{matrix.jsengine}} == "JSC" ]]; then
373+
echo "Using JSC instead of Hermes"
374+
sed -i 's/hermesEnabled=true/hermesEnabled=false/' android/gradle.properties
375+
fi
376+
372377
# Build
373378
cd android
374379
CAPITALIZED_FLAVOR=$(echo "${{ matrix.flavor }}" | awk '{print toupper(substr($0, 1, 1)) substr($0, 2)}')

0 commit comments

Comments
 (0)