From a650f98d96bba0a189bdef5e97105186a27184a7 Mon Sep 17 00:00:00 2001 From: siddhanta-rath Date: Thu, 10 Feb 2022 20:47:08 +0530 Subject: [PATCH 1/4] feat : add external http sensor at optimus job dependency --- odpf/optimus/core/v1beta1/runtime.proto | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/odpf/optimus/core/v1beta1/runtime.proto b/odpf/optimus/core/v1beta1/runtime.proto index 4981c428..0ee14fb5 100644 --- a/odpf/optimus/core/v1beta1/runtime.proto +++ b/odpf/optimus/core/v1beta1/runtime.proto @@ -332,6 +332,7 @@ message JobConfigItem { message JobDependency { string name = 1; string type = 2; // intra/inter/extra + HttpSensor http_sensor_dependency = 3; // http sensor dependency } message InstanceSpec { @@ -870,3 +871,9 @@ message GetBackupResponse { BackupSpec spec = 1; repeated string urn = 2; } + +message HttpSensor { + string url = 1; + map headers = 2; + map request_params = 3; +} \ No newline at end of file From 557b6e8525abbeeb254629ee88338d5f827d7d3c Mon Sep 17 00:00:00 2001 From: siddhanta-rath Date: Fri, 11 Feb 2022 14:10:50 +0530 Subject: [PATCH 2/4] feat : added name attribute at http sensor message --- odpf/optimus/core/v1beta1/runtime.proto | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/odpf/optimus/core/v1beta1/runtime.proto b/odpf/optimus/core/v1beta1/runtime.proto index 0ee14fb5..2d81b6b6 100644 --- a/odpf/optimus/core/v1beta1/runtime.proto +++ b/odpf/optimus/core/v1beta1/runtime.proto @@ -873,7 +873,10 @@ message GetBackupResponse { } message HttpSensor { - string url = 1; - map headers = 2; - map request_params = 3; -} \ No newline at end of file + string name = 1; + string url = 2; + map headers = 3; + map request_params = 4; +} + + From 26b87bec6e1952bd2ebed9a80c90590b7850e8a1 Mon Sep 17 00:00:00 2001 From: siddhanta-rath Date: Fri, 11 Feb 2022 14:13:55 +0530 Subject: [PATCH 3/4] fix: removed whitespace from HttpSensor message --- odpf/optimus/core/v1beta1/runtime.proto | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/odpf/optimus/core/v1beta1/runtime.proto b/odpf/optimus/core/v1beta1/runtime.proto index 2d81b6b6..6abc6799 100644 --- a/odpf/optimus/core/v1beta1/runtime.proto +++ b/odpf/optimus/core/v1beta1/runtime.proto @@ -877,6 +877,4 @@ message HttpSensor { string url = 2; map headers = 3; map request_params = 4; -} - - +} \ No newline at end of file From 07376fe17061f034d451fb32a936c63cece15f2c Mon Sep 17 00:00:00 2001 From: siddhanta-rath Date: Sun, 27 Feb 2022 22:58:21 +0530 Subject: [PATCH 4/4] fix: renamed message Name and parameters for http dependency --- odpf/optimus/core/v1beta1/runtime.proto | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/odpf/optimus/core/v1beta1/runtime.proto b/odpf/optimus/core/v1beta1/runtime.proto index 6abc6799..6faf5416 100644 --- a/odpf/optimus/core/v1beta1/runtime.proto +++ b/odpf/optimus/core/v1beta1/runtime.proto @@ -332,7 +332,7 @@ message JobConfigItem { message JobDependency { string name = 1; string type = 2; // intra/inter/extra - HttpSensor http_sensor_dependency = 3; // http sensor dependency + HttpDependency http_dependency = 3; // http sensor dependency } message InstanceSpec { @@ -872,9 +872,9 @@ message GetBackupResponse { repeated string urn = 2; } -message HttpSensor { +message HttpDependency { string name = 1; string url = 2; map headers = 3; - map request_params = 4; + map params = 4; } \ No newline at end of file