From a7581c36b1f95c07e5d336a3a6aff893b65bcf4d Mon Sep 17 00:00:00 2001 From: Sandeep Bhardwaj Date: Mon, 21 Feb 2022 16:34:53 +0530 Subject: [PATCH 1/3] feat: add ability to delete secret for a project --- odpf/optimus/core/v1beta1/runtime.proto | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/odpf/optimus/core/v1beta1/runtime.proto b/odpf/optimus/core/v1beta1/runtime.proto index f7c8d1df..283b09d6 100644 --- a/odpf/optimus/core/v1beta1/runtime.proto +++ b/odpf/optimus/core/v1beta1/runtime.proto @@ -124,6 +124,13 @@ service RuntimeService { }; } + // DeleteSecret deletes a secret for a project + rpc DeleteSecret(DeleteSecretRequest) returns (DeleteSecretResponse) { + option (google.api.http) = { + delete: "/v1beta1/project/{project_name}/secret/{secret_name}" + }; + } + // ListProjects returns list of registered projects and configurations rpc ListProjects(ListProjectsRequest) returns (ListProjectsResponse) { option (google.api.http) = { @@ -603,6 +610,13 @@ message ListSecretsResponse { repeated Secret secrets = 1; } +message DeleteSecretRequest { + string project_name = 1; + string secret_name = 2; +} + +message DeleteSecretResponse {} + message ListProjectsRequest {} message ListProjectsResponse { From 3cd36d4122fa222517691fa6adfc1372c5e26b92 Mon Sep 17 00:00:00 2001 From: Sandeep Bhardwaj Date: Fri, 25 Feb 2022 10:34:31 +0530 Subject: [PATCH 2/3] feat: add namespace_name for proxy authentication --- odpf/optimus/core/v1beta1/runtime.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/odpf/optimus/core/v1beta1/runtime.proto b/odpf/optimus/core/v1beta1/runtime.proto index 283b09d6..bba822f8 100644 --- a/odpf/optimus/core/v1beta1/runtime.proto +++ b/odpf/optimus/core/v1beta1/runtime.proto @@ -613,6 +613,7 @@ message ListSecretsResponse { message DeleteSecretRequest { string project_name = 1; string secret_name = 2; + string namespace_name = 3; } message DeleteSecretResponse {} From 19418f68b938c7408c251b38b9ae683f80bac07a Mon Sep 17 00:00:00 2001 From: Sandeep Bhardwaj Date: Mon, 21 Feb 2022 16:34:53 +0530 Subject: [PATCH 3/3] feat: add ability to delete secret for a project --- odpf/optimus/core/v1beta1/runtime.proto | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/odpf/optimus/core/v1beta1/runtime.proto b/odpf/optimus/core/v1beta1/runtime.proto index 5461b3b9..1f0a8e08 100644 --- a/odpf/optimus/core/v1beta1/runtime.proto +++ b/odpf/optimus/core/v1beta1/runtime.proto @@ -124,6 +124,13 @@ service RuntimeService { }; } + // DeleteSecret deletes a secret for a project + rpc DeleteSecret(DeleteSecretRequest) returns (DeleteSecretResponse) { + option (google.api.http) = { + delete: "/v1beta1/project/{project_name}/secret/{secret_name}" + }; + } + // ListProjects returns list of registered projects and configurations rpc ListProjects(ListProjectsRequest) returns (ListProjectsResponse) { option (google.api.http) = { @@ -604,6 +611,13 @@ message ListSecretsResponse { repeated Secret secrets = 1; } +message DeleteSecretRequest { + string project_name = 1; + string secret_name = 2; +} + +message DeleteSecretResponse {} + message ListProjectsRequest {} message ListProjectsResponse {