Merge pull request #10 from odpf/optimus-register-instance-proto

kushsharma · web-flow · commit 611b26c69bda · 2021-06-03T19:36:43.000+05:30
refactor: register instance api path for runtime_service.proto
diff --git a/odpf/optimus/runtime_service.proto b/odpf/optimus/runtime_service.proto
@@ -122,7 +122,7 @@ service RuntimeService {
     // RegisterInstance is an internal admin command used during task execution
     rpc RegisterInstance(RegisterInstanceRequest) returns (RegisterInstanceResponse) {
         option (google.api.http) = {
-            post: "/api/v1/instance"
+            post: "/api/v1/project/{project_name}/job/{job_name}/instance"
             body: "*"
         };
     }
@@ -167,7 +167,7 @@ service RuntimeService {
             body: "*"
         };
     }
-    // TODO(kush.sharma): unsupported ATM
+    // TODO(kush.sharma): disabled ATM
     //rpc DeleteResource(DeleteResourceRequest) returns (DeleteResourceResponse) {}
 
 }

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ service RuntimeService {`
`122`	`122`	`// RegisterInstance is an internal admin command used during task execution`
`123`	`123`	`rpc RegisterInstance(RegisterInstanceRequest) returns (RegisterInstanceResponse) {`
`124`	`124`	`option (google.api.http) = {`
`125`		`- post: "/api/v1/instance"`
	`125`	`+ post: "/api/v1/project/{project_name}/job/{job_name}/instance"`
`126`	`126`	`body: "*"`
`127`	`127`	`};`
`128`	`128`	`}`
`@@ -167,7 +167,7 @@ service RuntimeService {`
`167`	`167`	`body: "*"`
`168`	`168`	`};`
`169`	`169`	`}`
`170`		`- // TODO(kush.sharma): unsupported ATM`
	`170`	`+ // TODO(kush.sharma): disabled ATM`
`171`	`171`	`//rpc DeleteResource(DeleteResourceRequest) returns (DeleteResourceResponse) {}`
`172`	`172`
`173`	`173`	`}`