Skip to content

Commit 4eac90b

Browse files
committed
refactor(entropy): remove resource.id field and make urn the only unique identifier needed in requests
1 parent 31aade5 commit 4eac90b

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

odpf/entropy/v1beta1/service.proto

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ package odpf.entropy.v1beta1;
55
import "google/api/annotations.proto";
66
import "google/protobuf/field_mask.proto";
77
import "google/protobuf/struct.proto";
8+
import "google/protobuf/timestamp.proto";
89

910
option go_package = "github.com/odpf/proton/entropy/v1beta1;entropyv1beta1";
1011
option java_multiple_files = true;
@@ -15,7 +16,7 @@ option java_outer_classname = "EntropyServiceProto";
1516
service ResourceService {
1617
rpc ListResources(ListResourcesRequest) returns (ListResourcesResponse) {
1718
option (google.api.http) = {
18-
get: "/v1beta1/resources/"
19+
get: "/v1beta1/resources"
1920
};
2021
}
2122

@@ -47,14 +48,15 @@ service ResourceService {
4748
}
4849

4950
message Resource {
50-
string id = 1;
51-
string urn = 2;
52-
string name = 3;
53-
string parent = 4;
54-
string kind = 5;
55-
google.protobuf.Value configs = 6;
51+
string urn = 1;
52+
string name = 2;
53+
string parent = 3;
54+
string kind = 4;
55+
google.protobuf.Value configs = 5;
56+
map<string, string> labels = 6;
5657
string status = 7;
57-
map<string, string> labels = 8;
58+
google.protobuf.Timestamp created_at = 8;
59+
google.protobuf.Timestamp updated_at = 9;
5860
}
5961

6062
message ListResourcesRequest {
@@ -68,19 +70,18 @@ message ListResourcesResponse {
6870

6971
message GetResourceRequest {
7072
string urn = 1;
71-
string kind = 2;
7273
}
7374

7475
message GetResourceResponse {
7576
Resource resource = 1;
7677
}
7778

7879
message CreateResourceRequest {
79-
Resource resource = 3;
80+
Resource resource = 1;
8081
}
8182

8283
message CreateResourceResponse {
83-
Resource resource = 3;
84+
Resource resource = 1;
8485
}
8586

8687
message UpdateResourceRequest {
@@ -94,7 +95,6 @@ message UpdateResourceResponse {
9495

9596
message DeleteResourceRequest {
9697
string urn = 1;
97-
string kind = 2;
9898
}
9999

100100
message DeleteResourceResponse {}

0 commit comments

Comments
 (0)