Skip to content

Commit 0acbe8a

Browse files
authored
refactor!: drop ml prefix from types for feature, model (#206)
1 parent 449cade commit 0acbe8a

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ package odpf.assets.v1beta2;
55
import "google/protobuf/timestamp.proto";
66

77
option go_package = "github.com/odpf/proton/assets/v1beta2;assetsv1beta2";
8-
option java_outer_classname = "MLFeatureProto";
8+
option java_outer_classname = "FeatureProto";
99
option java_package = "io.odpf.assets";
1010

11-
// MLFeature is a Machine Learning(ML) feature. In machine learning, a feature
11+
// Feature is a Machine Learning(ML) feature. In machine learning, a feature
1212
// is an individual measurable property, typically represented by a column,
1313
// that serves as an input for Machine Learning (ML) algorithms.
14-
message MLFeature {
14+
message Feature {
1515
// The name of the field.
1616
string name = 1;
1717

@@ -26,10 +26,10 @@ message MLFeature {
2626
string entity_name = 4;
2727
}
2828

29-
// MLFeatureTable is a Machine Learning(ML) feature table or view that
29+
// FeatureTable is a Machine Learning(ML) feature table or view that
3030
// represents a logical group of time-series feature data as it is found in a
3131
// data source.
32-
message MLFeatureTable {
32+
message FeatureTable {
3333
// An entity is a collection of semantically related features. Users define
3434
// entities to map to the domain of their use case. For example, a
3535
// ride-hailing service could have customers and drivers as their entities,
@@ -54,7 +54,7 @@ message MLFeatureTable {
5454
repeated Entity entities = 2;
5555

5656
// Features that are part of the table, akin to columns in a table.
57-
repeated MLFeature features = 3;
57+
repeated Feature features = 3;
5858

5959
// The timestamp when the feature table was created.
6060
google.protobuf.Timestamp create_time = 101;
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ import "google/protobuf/struct.proto";
66
import "google/protobuf/timestamp.proto";
77

88
option go_package = "github.com/odpf/proton/assets/v1beta2;assetsv1beta2";
9-
option java_outer_classname = "MLModelProto";
9+
option java_outer_classname = "ModelProto";
1010
option java_package = "io.odpf.assets";
1111

12-
// MLModel represents a Machine Learning(ML) Model. Models are algorithms trained
13-
// on data to find patterns or make predictions. Models typically consume
14-
// ML features to generate a meaningful output. The inputs can also include
15-
// contextual information that is made available in realtime as part of the
16-
// request to the model server.
17-
message MLModel {
12+
// Model represents a Data Science Model commonly used for Machine Learning
13+
// (ML). Models are algorithms trained on data to find patterns or make
14+
// predictions. Models typically consume ML features to generate a meaningful
15+
// output. The inputs can also include contextual information that is made
16+
// available in realtime as part of the request to the model server.
17+
message Model {
1818
// Schema of the model's inputs and outputs. Strongly inspired by
1919
// https://mlflow.org/docs/latest/python_api/mlflow.models.html#mlflow.models.ModelSignature.
2020
message Signature {

0 commit comments

Comments
 (0)