Skip to content

Commit 9e4ee62

Browse files
fix(metabase): unable to login via username and password (#262)
1 parent fb2b2de commit 9e4ee62

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

plugins/extractors/metabase/metabase.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,16 @@ func (e *Extractor) Init(ctx context.Context, configMap map[string]interface{})
7878
if err != nil {
7979
return plugins.InvalidConfigError{}
8080
}
81-
8281
e.client = &http.Client{
83-
Timeout: 4 * time.Second,
82+
Timeout: 30 * time.Second,
8483
}
8584

8685
// get session id for further api calls in metabase
87-
if e.sessionID, err = e.getSessionID(); err != nil {
86+
sessionID, err := e.getSessionID()
87+
if err != nil {
8888
return errors.Wrap(err, "failed to fetch session ID")
8989
}
90+
e.sessionID = sessionID
9091

9192
return nil
9293
}
@@ -224,6 +225,7 @@ func (e *Extractor) getSessionID() (sessionID string, err error) {
224225
if err != nil {
225226
return
226227
}
228+
227229
return data.ID, nil
228230
}
229231

@@ -239,7 +241,7 @@ func (e *Extractor) makeRequest(method, url string, payload interface{}, data in
239241
return errors.Wrap(err, "failed to create request")
240242
}
241243
req.Header.Set("Content-Type", "application/json")
242-
req.Header.Set("X-Metabase-Session", e.config.SessionID)
244+
req.Header.Set("X-Metabase-Session", e.sessionID)
243245

244246
res, err := e.client.Do(req)
245247
if err != nil {

plugins/extractors/metabase/models.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package metabase
33
import "time"
44

55
const (
6-
timestampFormat = "2006-01-02T15:04:05.999999"
6+
timestampFormat = "2006-01-02T15:04:05.999999Z"
77
)
88

99
type Dashboard struct {

0 commit comments

Comments
 (0)