fix: rm instrumentation for lint command

- Remove metrics/instrumentation for lint command since it does not
 provide any value.
- Minor refactor to move resposibility of exiting with error from
  cmd.New() to main().

Author: sudo-suhas

cmd/helpers.go

@@ -7,7 +7,6 @@ import (
 
 	"github.com/MakeNowJust/heredoc"
 	"github.com/odpf/meteor/agent"
-	"github.com/odpf/meteor/metrics"
 	"github.com/odpf/meteor/plugins"
 	"github.com/odpf/meteor/recipe"
 	"github.com/odpf/meteor/registry"
@@ -18,7 +17,7 @@ import (
 )
 
 // LintCmd creates a command object for linting recipes
-func LintCmd(lg log.Logger, mt *metrics.StatsdMonitor) *cobra.Command {
+func LintCmd(lg log.Logger) *cobra.Command {
 	var (
 		report   [][]string
 		success  = 0
@@ -53,7 +52,6 @@ func LintCmd(lg log.Logger, mt *metrics.StatsdMonitor) *cobra.Command {
 				ExtractorFactory: registry.Extractors,
 				ProcessorFactory: registry.Processors,
 				SinkFactory:      registry.Sinks,
-				Monitor:          mt,
 				Logger:           lg,
 			})
 

cmd/lint.go

@@ -2,8 +2,6 @@ package cmd
 
 import (
 	"errors"
-	"fmt"
-	"os"
 
 	"github.com/MakeNowJust/heredoc"
 	"github.com/odpf/meteor/config"
@@ -14,14 +12,11 @@ import (
 	"github.com/spf13/cobra"
 )
 
-const exitError = 1
-
 // New adds all child commands to the root command and sets flags appropriately.
-func New() *cobra.Command {
+func New() (*cobra.Command, error) {
 	cfg, err := config.Load("./meteor.yaml")
 	if err != nil && !errors.As(err, &saltconfig.ConfigFileNotFoundError{}) {
-		fmt.Printf("ERROR: %s\n", err.Error())
-		os.Exit(exitError)
+		return nil, err
 	}
 
 	lgLvl := cfg.LogLevel
@@ -31,13 +26,6 @@ func New() *cobra.Command {
 	lg := log.NewLogrus(log.LogrusWithLevel(lgLvl))
 	plugins.SetLog(lg)
 
-	// Setup statsd monitor to collect monitoring metrics
-	mt, err := newStatsdMonitor(cfg)
-	if err != nil {
-		fmt.Printf("ERROR: %s\n", err.Error())
-		os.Exit(exitError)
-	}
-
 	var cmd = &cobra.Command{
 		Use:           "meteor <command> <subcommand> [flags]",
 		Short:         "Metadata CLI",
@@ -71,8 +59,8 @@ func New() *cobra.Command {
 	cmd.AddCommand(ListCmd(lg))
 	cmd.AddCommand(InfoCmd(lg))
 	cmd.AddCommand(RunCmd())
-	cmd.AddCommand(LintCmd(lg, mt))
+	cmd.AddCommand(LintCmd(lg))
 	cmd.AddCommand(NewCmd(lg))
 
-	return cmd
+	return cmd, nil
 }

cmd/root.go

@@ -12,6 +12,7 @@ import (
 	"github.com/MakeNowJust/heredoc"
 	"github.com/odpf/meteor/agent"
 	"github.com/odpf/meteor/config"
+	"github.com/odpf/meteor/metrics"
 	"github.com/odpf/meteor/plugins"
 	"github.com/odpf/meteor/recipe"
 	"github.com/odpf/meteor/registry"
@@ -140,3 +141,15 @@ func RunCmd() *cobra.Command {
 
 	return cmd
 }
+
+func newStatsdMonitor(cfg config.Config) (*metrics.StatsdMonitor, error) {
+	if !cfg.StatsdEnabled {
+		return nil, nil
+	}
+
+	client, err := metrics.NewStatsdClient(cfg.StatsdHost)
+	if err != nil {
+		return nil, err
+	}
+	return metrics.NewStatsdMonitor(client, cfg.StatsdPrefix), nil
+}

cmd/run.go

@@ -20,7 +20,12 @@ const (
 
 func main() {
 	// Execute the root command
-	root := cmd.New()
+	root, err := cmd.New()
+	if err != nil {
+		fmt.Printf("ERROR: %s\n", err.Error())
+		os.Exit(exitError)
+	}
+
 	cmd, err := root.ExecuteC()
 
 	if err == nil {

main.go

@@ -111,7 +111,10 @@ func TestMySqlToKafka(t *testing.T) {
 	if err != nil {
 		t.Error(err)
 	}
-	command := cmd.New(utils.Logger, nil, cfg)
+	command, err := cmd.New(utils.Logger, nil, cfg)
+	if err != nil {
+		t.Fatal(err)
+	}
 	command.SetArgs([]string{"run", "mysql_kafka.yml"})
 	if err := command.Execute(); err != nil {
 		if strings.HasPrefix(err.Error(), "unknown command ") {