diff --git a/.golangci.yml b/.golangci.yml index 1b9a706c21a..6ce257399a5 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -33,9 +33,6 @@ linters: gosec: excludes: - G601 - govet: - enable: - - fieldalignment lll: line-length: 120 misspell: diff --git a/docs/reference/api.md b/docs/reference/api.md index bcc095c7191..c61e0f308df 100644 --- a/docs/reference/api.md +++ b/docs/reference/api.md @@ -371,7 +371,7 @@ _Appears in:_ - +RayCronJob is the Schema for the raycronjobs API diff --git a/ray-operator/apis/ray/v1/raycronjob_types.go b/ray-operator/apis/ray/v1/raycronjob_types.go index 6e2396083c7..fbce946d8cb 100644 --- a/ray-operator/apis/ray/v1/raycronjob_types.go +++ b/ray-operator/apis/ray/v1/raycronjob_types.go @@ -34,7 +34,7 @@ type RayCronJobStatus struct { // +kubebuilder:resource:categories=all // +kubebuilder:storageversion // -//nolint:govet // RayCronJob is the Schema for the raycronjobs API +// RayCronJob is the Schema for the raycronjobs API type RayCronJob struct { metav1.TypeMeta `json:",inline"` metav1.ObjectMeta `json:"metadata,omitempty"` diff --git a/ray-operator/apis/ray/v1/rayjob_types.go b/ray-operator/apis/ray/v1/rayjob_types.go index e5829dd53d9..474b31e8eb4 100644 --- a/ray-operator/apis/ray/v1/rayjob_types.go +++ b/ray-operator/apis/ray/v1/rayjob_types.go @@ -206,8 +206,6 @@ type RayJobStatusInfo struct { } // RayJobSpec defines the desired state of RayJob -// -//nolint:govet // Prevent reordering fields and removing comments type RayJobSpec struct { // ActiveDeadlineSeconds is the duration in seconds that the RayJob may be active before // KubeRay actively tries to terminate the RayJob; value must be positive integer. diff --git a/ray-operator/controllers/ray/rayjob_controller_unit_test.go b/ray-operator/controllers/ray/rayjob_controller_unit_test.go index 38db8b1fd15..a6791a845e4 100644 --- a/ray-operator/controllers/ray/rayjob_controller_unit_test.go +++ b/ray-operator/controllers/ray/rayjob_controller_unit_test.go @@ -536,7 +536,6 @@ func TestEmitRayJobExecutionDuration(t *testing.T) { rayJobUID := types.UID("test-job-uid") mockTime := time.Now().Add(-60 * time.Second) - //nolint:govet // disable govet to keep the order of the struct fields tests := []struct { name string originalRayJobStatus rayv1.RayJobStatus diff --git a/ray-operator/pkg/client/applyconfiguration/ray/v1/raycronjob.go b/ray-operator/pkg/client/applyconfiguration/ray/v1/raycronjob.go index 6d435a03316..1697482ae58 100644 --- a/ray-operator/pkg/client/applyconfiguration/ray/v1/raycronjob.go +++ b/ray-operator/pkg/client/applyconfiguration/ray/v1/raycronjob.go @@ -10,6 +10,8 @@ import ( // RayCronJobApplyConfiguration represents a declarative configuration of the RayCronJob type for use // with apply. +// +// RayCronJob is the Schema for the raycronjobs API type RayCronJobApplyConfiguration struct { metav1.TypeMetaApplyConfiguration `json:",inline"` *metav1.ObjectMetaApplyConfiguration `json:"metadata,omitempty"`