update comment

koriym · web-flow · commit cb1c24a82a3f · 2020-03-08T13:33:50.000+09:00
diff --git a/demo/05a-constructor-binding.php b/demo/05a-constructor-binding.php
@@ -13,7 +13,7 @@ class PdoModuleLegacyNaming extends AbstractModule
 {
     protected function configure()
     {
-        // dsn=pdo_dsn works
+        // 'dsn=pdo_dsn' (still) works
         $this->bind(PDO::class)->toConstructor(\PDO::class, 'dsn=pdo_dsn');
         $this->bind()->annotatedWith('pdo_dsn')->toInstance('sqlite::memory:');
     }
@@ -23,7 +23,7 @@ class PdoModule extends AbstractModule
 {
     protected function configure()
     {
-        // 'dsn' => 'pdo_dsn' works
+        // ['dsn' => 'pdo_dsn'] works (recommended)
         $this->bind(PDO::class)->toConstructor(\PDO::class, ['dsn' => 'pdo_dsn']);
         $this->bind()->annotatedWith('pdo_dsn')->toInstance('sqlite::memory:');
     }

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ class PdoModuleLegacyNaming extends AbstractModule`
`13`	`13`	`{`
`14`	`14`	`protected function configure()`
`15`	`15`	`{`
`16`		`- // dsn=pdo_dsn works`
	`16`	`+ // 'dsn=pdo_dsn' (still) works`
`17`	`17`	`$this->bind(PDO::class)->toConstructor(\PDO::class, 'dsn=pdo_dsn');`
`18`	`18`	`$this->bind()->annotatedWith('pdo_dsn')->toInstance('sqlite::memory:');`
`19`	`19`	`}`
`@@ -23,7 +23,7 @@ class PdoModule extends AbstractModule`
`23`	`23`	`{`
`24`	`24`	`protected function configure()`
`25`	`25`	`{`
`26`		`- // 'dsn' => 'pdo_dsn' works`
	`26`	`+ // ['dsn' => 'pdo_dsn'] works (recommended)`
`27`	`27`	`$this->bind(PDO::class)->toConstructor(\PDO::class, ['dsn' => 'pdo_dsn']);`
`28`	`28`	`$this->bind()->annotatedWith('pdo_dsn')->toInstance('sqlite::memory:');`
`29`	`29`	`}`