Skip to content

Commit d19c152

Browse files
committed
New technique
1 parent e539202 commit d19c152

File tree

2 files changed

+14
-37
lines changed

2 files changed

+14
-37
lines changed

.github/workflows/presto-test-composite.yml

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,26 +50,30 @@ jobs:
5050
repository: ${{ inputs.presto_repository }}
5151
ref: ${{ inputs.presto_commit }}
5252
path: presto
53+
- name: Get Presto Pinned Velox Version
54+
id: get-presto-pinned-velox-version
55+
if: ${{ inputs.build_upstream && inputs.presto_worker_type != 'java' }}
56+
run: |
57+
pushd presto/presto-native-execution
58+
make submodules
59+
cd velox
60+
PRESTO_PINNED_VELOX_SHA=$(git rev-parse HEAD)
61+
echo "Found Presto pinned Velox SHA: ${PRESTO_PINNED_VELOX_SHA}"
62+
echo "PRESTO_PINNED_VELOX_SHA=${PRESTO_PINNED_VELOX_SHA}" >> $GITHUB_OUTPUT
63+
popd
5364
- name: Checkout Velox
5465
if: ${{ inputs.presto_worker_type != 'java' }}
5566
uses: actions/checkout@v4
5667
with:
57-
repository: ${{ inputs.velox_repository }}
58-
ref: ${{ inputs.velox_commit }}
68+
repository: ${{ inputs.build_upstream && 'facebookincubator/velox' || inputs.velox_repository }}
69+
ref: ${{ inputs.build_upstream && steps.get-presto-pinned-velox-version.outputs.PRESTO_PINNED_VELOX_SHA || inputs.velox_commit }}
5970
path: velox
6071
- name: Checkout Velox Testing
61-
# checkout branch github.ref_name to automatically match the workflow branch
6272
uses: actions/checkout@v4
6373
with:
6474
repository: rapidsai/velox-testing
65-
ref: ${{ github.ref_name }}
75+
ref: ${{ github.ref_name }} # automatically match the workflow branch
6676
path: velox-testing
67-
- name: Change Velox to match upstream Presto
68-
if: ${{ inputs.build_upstream && inputs.presto_worker_type != 'java' }}
69-
run: |
70-
pushd velox-testing/presto/scripts
71-
./checkout_velox_to_match_presto.sh
72-
popd
7377
- name: Download Presto Dependencies Container Image
7478
if: ${{ inputs.presto_worker_type != 'java' }}
7579
env:

presto/scripts/checkout_velox_to_match_presto.sh

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)