Warnings are errors#299
Merged
rapids-bot[bot] merged 1 commit intoJul 28, 2021
Merged
Conversation
dantegd
added
improvement
Contributor
|
I'm not a fan of relative paths (#include "../test_utils.h"), but PR looks good |
BradReesWork
approved these changes
Jul 28, 2021
Contributor
|
@gpucibot merge |
Contributor
Author
Me neither, but I didn't change that, it was already there. If the build options don't include the base path to the header, and the header is not part of the library public interface, then relative paths are a necessity. |
This was referenced Jul 30, 2021
rapids-bot Bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
Adds `-Werror=all-warnings` NVCC flag to ensure all CUDA device code warnings are treated as errors. Only enabled on CUDA 11.2+ because CUDA 11.0 has PTXAS warnings that go away in newer CUDA versions. Missed this in #299. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #307
Merged
rapids-bot Bot
pushed a commit
that referenced
this pull request
Aug 5, 2021
Warnings missed in #299... Authors: - Mark Harris (https://github.com/harrism) Approvers: - Divye Gala (https://github.com/divyegala) - Dante Gama Dessavre (https://github.com/dantegd) URL: #311
rapids-bot Bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Aug 10, 2021
Depends on NVIDIA/raft#299 Depends on NVIDIA/raft#311 Fixes #4086 This PR enables -Wall (warnings are errors) and fixes all current compiler warnings. Compiler warnings should almost never be ignored. -Wall helps prevent hard-to-find bugs. Tested with both Release and Debug builds since more warnings are typically reported in debug builds. In any file I touched, I also cleaned up the includes so that they are grouped and sorted and ordered from "near" to "far" (relative to the file that is including). Also cleaned up many instances of `size_t` --> `std::size_t`, however I will leave a global search and replace for a separate PR to make reviewing easier. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Robert Maynard (https://github.com/robertmaynard) - William Hicks (https://github.com/wphicks) - Dante Gama Dessavre (https://github.com/dantegd) URL: #4075
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Depends on NVIDIA/raft#299 Depends on NVIDIA/raft#311 Fixes rapidsai#4086 This PR enables -Wall (warnings are errors) and fixes all current compiler warnings. Compiler warnings should almost never be ignored. -Wall helps prevent hard-to-find bugs. Tested with both Release and Debug builds since more warnings are typically reported in debug builds. In any file I touched, I also cleaned up the includes so that they are grouped and sorted and ordered from "near" to "far" (relative to the file that is including). Also cleaned up many instances of `size_t` --> `std::size_t`, however I will leave a global search and replace for a separate PR to make reviewing easier. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Robert Maynard (https://github.com/robertmaynard) - William Hicks (https://github.com/wphicks) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4075
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
This PR fixes current RAFT C++/CUDA compilation warnings and turns on -Wall to treat warnings as errors. Fixes NVIDIA#225 Fixes NVIDIA#289 Authors: - Mark Harris (https://github.com/harrism) Approvers: - Brad Rees (https://github.com/BradReesWork) - Corey J. Nolet (https://github.com/cjnolet) URL: NVIDIA#299
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
Adds `-Werror=all-warnings` NVCC flag to ensure all CUDA device code warnings are treated as errors. Only enabled on CUDA 11.2+ because CUDA 11.0 has PTXAS warnings that go away in newer CUDA versions. Missed this in NVIDIA#299. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: NVIDIA#307
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
Warnings missed in NVIDIA#299... Authors: - Mark Harris (https://github.com/harrism) Approvers: - Divye Gala (https://github.com/divyegala) - Dante Gama Dessavre (https://github.com/dantegd) URL: NVIDIA#311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes current RAFT C++/CUDA compilation warnings and turns on -Wall to treat warnings as errors.
Fixes #225
Fixes #289