Skip to content

Commit ed14bb7

Browse files
committed
Review changes:
1. Removed include-dir settings from tests/CMakeLists. 2. Removed version header from c-api source and tests. 3. Added version header to c-api header. 4. Modified `jextract` script for the include directory, so as to find the version header.
1 parent b75db0f commit ed14bb7

5 files changed

Lines changed: 4 additions & 6 deletions

File tree

cpp/include/cuvs/core/c_api.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
#pragma once
1818

19+
#include <cuvs/version_config.hpp>
20+
1921
#include <cuda_runtime.h>
2022
#include <stdbool.h>
2123
#include <stdint.h>

cpp/src/core/c_api.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
#include <cuvs/core/c_api.h>
1818
#include <cuvs/core/exceptions.hpp>
19-
#include <cuvs/version_config.hpp>
2019

2120
#include <raft/core/resource/cuda_stream.hpp>
2221
#include <raft/core/resources.hpp>

cpp/tests/CMakeLists.txt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# =============================================================================
2-
# Copyright (c) 2021-2025, NVIDIA CORPORATION.
2+
# Copyright (c) 2021-2024, NVIDIA CORPORATION.
33
#
44
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
55
# in compliance with the License. You may obtain a copy of the License at
@@ -292,9 +292,6 @@ if(TARGET cuvs::c_api)
292292
endif()
293293

294294
add_executable(cuvs_c_test core/c_api.c)
295-
target_include_directories(
296-
cuvs_c_test PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/../include>"
297-
)
298295
target_link_libraries(cuvs_c_test PUBLIC cuvs::c_api)
299296

300297
add_executable(cuvs_c_neighbors_test neighbors/c_api.c)

cpp/tests/core/c_api.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616

1717
#include <cuvs/core/c_api.h>
18-
#include <cuvs/version_config.hpp>
1918

2019
#include <stdio.h>
2120
#include <stdlib.h>

java/panama-bindings/generate-bindings.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ jextract \
3636
--include-dir "${REPODIR}"/java/internal/build/_deps/dlpack-src/include/ \
3737
--include-dir "${CUDA_INCLUDE_DIR}" \
3838
--include-dir "${REPODIR}"/cpp/include \
39+
--include-dir "${REPODIR}"/cpp/build/include \
3940
--output "${REPODIR}/java/cuvs-java/src/main/java22/" \
4041
--target-package ${TARGET_PACKAGE} \
4142
--library cuvs_c \

0 commit comments

Comments
 (0)