Skip to content

Commit df4ea06

Browse files
authored
disallow fallback to Make in Python builds (#636)
Contributes to rapidsai/build-planning#146 Proposes: * setting `[tool.scikit-build].ninja.make-fallback = false`, so `scikit-build-core` will not silently fallback to using GNU Make if `ninja` is not available * including all groups in `dependencies.yaml` with `output_types: pyproject` in `output_types: requirements` as well. - *So that, for example, they show up in the solved environment in RAPIDS devcontainers (https://github.com/rapidsai/devcontainers)* Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #636
1 parent c366d61 commit df4ea06

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

dependencies.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ dependencies:
397397
- *libcusparse114
398398
cuda_wheels:
399399
specific:
400-
- output_types: pyproject
400+
- output_types: [requirements, pyproject]
401401
matrices:
402402
- matrix:
403403
cuda: "12.*"

python/cuvs/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ build-dir = "build/{wheel_tag}"
104104
cmake.build-type = "Release"
105105
cmake.version = "CMakeLists.txt"
106106
minimum-version = "build-system.requires"
107-
ninja.make-fallback = true
107+
ninja.make-fallback = false
108108
sdist.reproducible = true
109109
wheel.packages = ["cuvs"]
110110

python/libcuvs/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ build-dir = "build/{wheel_tag}"
7777
cmake.build-type = "Release"
7878
cmake.version = "CMakeLists.txt"
7979
minimum-version = "build-system.requires"
80-
ninja.make-fallback = true
80+
ninja.make-fallback = false
8181
sdist.reproducible = true
8282
wheel.install-dir = "libcuvs"
8383
wheel.packages = ["libcuvs"]

0 commit comments

Comments
 (0)