Commit ba3ea5c
committed
Remove
I _think_ we can fully remove `KMeansMG`.
As is, KMeansMG is a thin wrapper around `KMeans` itself, with just the
`fit` method reimplemented. Looking at the implementation though, all it
does is call `cuvs::cluster::kmeans::fit` (with much less input
validation than it should) followed by `cuvs::cluster::kmeans::predict`
instead of a single call to `cuvs::cluster::kmeans::fit_predict` (like
`KMeans` does). Reading through the cuvs docs, I don't see a strong
reason why we can't just use `fit_predict` everywhere. Ripping out
`KMeansMG` does lead all tests to pass.KMeansMG
1 parent 87d7bb7 commit ba3ea5c
3 files changed
Lines changed: 2 additions & 233 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | 20 | | |
27 | 21 | | |
28 | 22 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
0 commit comments