Skip to content

Commit 9b85f85

Browse files
paulcam206Paul Campbell
andauthored
[iOS/Android/UWP/Shared] Fix handling of orphaned table child elements (microsoft#6408)
* [Shared] Fix parsing of `TableRow` and `TableCell` outside of `Table` Fixes microsoft#6393 * SWIG updates * Fix up Android rendering * Fix up iOS * Fix up UWP Co-authored-by: Paul Campbell <[email protected]>
1 parent 98443bf commit 9b85f85

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+944
-758
lines changed

source/android/adaptivecards/CMakeLists.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,22 +25,22 @@ add_library( # Sets the name of the library.
2525
# file are automatically included.
2626
../../shared/cpp/ObjectModel/jsoncpp.cpp
2727
../../shared/cpp/ObjectModel/ActionParserRegistration.cpp
28-
../../shared/cpp/ObjectModel/AdaptiveBase64Util.cpp
2928
../../shared/cpp/ObjectModel/ActionSet.cpp
29+
../../shared/cpp/ObjectModel/AdaptiveBase64Util.cpp
3030
../../shared/cpp/ObjectModel/AdaptiveCardParseException.cpp
3131
../../shared/cpp/ObjectModel/AdaptiveCardParseWarning.cpp
3232
../../shared/cpp/ObjectModel/AuthCardButton.cpp
3333
../../shared/cpp/ObjectModel/Authentication.cpp
34-
../../shared/cpp/ObjectModel/BaseActionElement.cpp
3534
../../shared/cpp/ObjectModel/BackgroundImage.cpp
35+
../../shared/cpp/ObjectModel/BaseActionElement.cpp
3636
../../shared/cpp/ObjectModel/BaseCardElement.cpp
3737
../../shared/cpp/ObjectModel/BaseElement.cpp
3838
../../shared/cpp/ObjectModel/BaseInputElement.cpp
3939
../../shared/cpp/ObjectModel/ChoiceInput.cpp
4040
../../shared/cpp/ObjectModel/ChoiceSetInput.cpp
41+
../../shared/cpp/ObjectModel/CollectionCoreElement.cpp
4142
../../shared/cpp/ObjectModel/Column.cpp
4243
../../shared/cpp/ObjectModel/ColumnSet.cpp
43-
../../shared/cpp/ObjectModel/CollectionTypeElement.cpp
4444
../../shared/cpp/ObjectModel/Container.cpp
4545
../../shared/cpp/ObjectModel/DateInput.cpp
4646
../../shared/cpp/ObjectModel/DateTimePreparsedToken.cpp
@@ -72,6 +72,7 @@ add_library( # Sets the name of the library.
7272
../../shared/cpp/ObjectModel/SemanticVersion.cpp
7373
../../shared/cpp/ObjectModel/SharedAdaptiveCard.cpp
7474
../../shared/cpp/ObjectModel/ShowCardAction.cpp
75+
../../shared/cpp/ObjectModel/StyledCollectionElement.cpp
7576
../../shared/cpp/ObjectModel/SubmitAction.cpp
7677
../../shared/cpp/ObjectModel/Table.cpp
7778
../../shared/cpp/ObjectModel/TableCell.cpp
@@ -86,8 +87,8 @@ add_library( # Sets the name of the library.
8687
../../shared/cpp/ObjectModel/ToggleVisibilityAction.cpp
8788
../../shared/cpp/ObjectModel/ToggleVisibilityTarget.cpp
8889
../../shared/cpp/ObjectModel/TokenExchangeResource.cpp
89-
../../shared/cpp/ObjectModel/UnknownElement.cpp
9090
../../shared/cpp/ObjectModel/UnknownAction.cpp
91+
../../shared/cpp/ObjectModel/UnknownElement.cpp
9192
../../shared/cpp/ObjectModel/Util.cpp
9293
src/main/cpp/objectmodel_wrap.cpp
9394
)

source/android/adaptivecards/src/AdaptiveCardObjectModel.i

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ STD_OPTIONAL(AdaptiveCards::VerticalContentAlignment, StdOptionalVerticalContent
112112
#include "../../../shared/cpp/ObjectModel/BaseCardElement.h"
113113
#include "../../../shared/cpp/ObjectModel/BaseActionElement.h"
114114
#include "../../../shared/cpp/ObjectModel/BaseInputElement.h"
115-
#include "../../../shared/cpp/ObjectModel/CollectionTypeElement.h"
115+
#include "../../../shared/cpp/ObjectModel/CollectionCoreElement.h"
116+
#include "../../../shared/cpp/ObjectModel/StyledCollectionElement.h"
116117
#include "../../../shared/cpp/ObjectModel/AdaptiveCardParseWarning.h"
117118
#include "../../../shared/cpp/ObjectModel/ActionParserRegistration.h"
118119
#include "../../../shared/cpp/ObjectModel/ElementParserRegistration.h"
@@ -183,7 +184,8 @@ STD_OPTIONAL(AdaptiveCards::VerticalContentAlignment, StdOptionalVerticalContent
183184
%shared_ptr(AdaptiveCards::BaseCardElementParser)
184185
%shared_ptr(AdaptiveCards::ActionElementParserWrapper)
185186
%shared_ptr(AdaptiveCards::BaseCardElementParserWrapper)
186-
%shared_ptr(AdaptiveCards::CollectionTypeElement)
187+
%shared_ptr(AdaptiveCards::CollectionCoreElement)
188+
%shared_ptr(AdaptiveCards::StyledCollectionElement)
187189
%shared_ptr(AdaptiveCards::FeatureRegistration)
188190
%shared_ptr(AdaptiveCards::BackgroundImage)
189191
%shared_ptr(AdaptiveCards::Container)
@@ -901,7 +903,8 @@ namespace Json {
901903
%include "../../../shared/cpp/ObjectModel/BaseActionElement.h"
902904
%include "../../../shared/cpp/ObjectModel/BaseInputElement.h"
903905
%include "../../../shared/cpp/ObjectModel/BackgroundImage.h"
904-
%include "../../../shared/cpp/ObjectModel/CollectionTypeElement.h"
906+
%include "../../../shared/cpp/ObjectModel/CollectionCoreElement.h"
907+
%include "../../../shared/cpp/ObjectModel/StyledCollectionElement.h"
905908
%include "../../../shared/cpp/ObjectModel/FeatureRegistration.h"
906909
%include "../../../shared/cpp/ObjectModel/SemanticVersion.h"
907910
%include "../../../shared/cpp/ObjectModel/Container.h"

0 commit comments

Comments
 (0)