Make go-getter use CABundles

Whether defined in secrets from Rancher or in a GitRepo resource,
go-getter (`helm.chart` field of `fleet.yaml`) is supposed to use the
certificates specified. First the certificate specified in the GitRepo
resource, then the ones from Rancher. It also should honor
`GitRepo.Spec.insecureSkipTLSVerify` (even when using the Rancher
certificates).

Refers to #3646

Author: p-se

e2e/assets/gitrepo/gitrepo.yaml

@@ -10,4 +10,17 @@ spec:
   targetNamespace: {{.TargetNamespace}}
   {{- end }}
   paths:
+  {{- if .Path }}
+  - {{.Path}}
+  {{- else }}
   - examples
+  {{- end }}
+  {{- if .CABundle}}
+  caBundle: {{.CABundle}}
+  {{- end}}
+  {{- if .HelmSecretName }}
+  helmSecretName: {{.HelmSecretName}}
+  {{- end }}
+  {{- if .HelmSecretNameForPaths }}
+  helmSecretNameForPaths: {{.HelmSecretNameForPaths}}
+  {{- end }}

e2e/single-cluster/gitrepo_test.go

@@ -31,6 +31,18 @@ const (
 	HTTPSPort = 4343
 )
 
+type gitRepoTestValues struct {
+	Name                   string
+	Repo                   string
+	Branch                 string
+	PollingInterval        string
+	TargetNamespace        string
+	Path                   string
+	CABundle               string
+	HelmSecretName         string
+	HelmSecretNameForPaths string
+}
+
 var _ = Describe("Monitoring Git repos via HTTP for change", Label("infra-setup"), func() {
 	var (
 		tmpDir           string
@@ -100,18 +112,12 @@ var _ = Describe("Monitoring Git repos via HTTP for change", Label("infra-setup"
 		})
 
 		JustBeforeEach(func() {
-			err := testenv.ApplyTemplate(k, testenv.AssetPath("gitrepo/gitrepo.yaml"), struct {
-				Name            string
-				Repo            string
-				Branch          string
-				PollingInterval string
-				TargetNamespace string
-			}{
-				gitrepoName,
-				inClusterRepoURL,
-				gh.Branch,
-				"15s",           // default
-				targetNamespace, // to avoid conflicts with other tests
+			err := testenv.ApplyTemplate(k, testenv.AssetPath("gitrepo/gitrepo.yaml"), gitRepoTestValues{
+				Name:            gitrepoName,
+				Repo:            inClusterRepoURL,
+				Branch:          gh.Branch,
+				PollingInterval: "15s",           // default
+				TargetNamespace: targetNamespace, // to avoid conflicts with other tests
 			})
 			Expect(err).ToNot(HaveOccurred())
 
@@ -157,18 +163,12 @@ var _ = Describe("Monitoring Git repos via HTTP for change", Label("infra-setup"
 		})
 
 		JustBeforeEach(func() {
-			err := testenv.ApplyTemplate(k, testenv.AssetPath("gitrepo/gitrepo.yaml"), struct {
-				Name            string
-				Repo            string
-				Branch          string
-				PollingInterval string
-				TargetNamespace string
-			}{
-				gitrepoName,
-				inClusterRepoURL,
-				gh.Branch,
-				"15s",           // default
-				targetNamespace, // to avoid conflicts with other tests
+			err := testenv.ApplyTemplate(k, testenv.AssetPath("gitrepo/gitrepo.yaml"), gitRepoTestValues{
+				Name:            gitrepoName,
+				Repo:            inClusterRepoURL,
+				Branch:          gh.Branch,
+				PollingInterval: "15s",           // default
+				TargetNamespace: targetNamespace, // to avoid conflicts with other tests
 			})
 			Expect(err).ToNot(HaveOccurred())
 
@@ -270,18 +270,12 @@ var _ = Describe("Monitoring Git repos via HTTP for change", Label("infra-setup"
 			clone, err = gh.Create(clonedir, testenv.AssetPath("gitrepo/sleeper-chart"), "examples")
 			Expect(err).ToNot(HaveOccurred())
 
-			err = testenv.ApplyTemplate(k, testenv.AssetPath("gitrepo/gitrepo.yaml"), struct {
-				Name            string
-				Repo            string
-				Branch          string
-				PollingInterval string
-				TargetNamespace string
-			}{
-				gitrepoName,
-				inClusterRepoURL,
-				gh.Branch,
-				"24h",           // prevent polling
-				targetNamespace, // to avoid conflicts with other tests
+			err = testenv.ApplyTemplate(k, testenv.AssetPath("gitrepo/gitrepo.yaml"), gitRepoTestValues{
+				Name:            gitrepoName,
+				Repo:            inClusterRepoURL,
+				Branch:          gh.Branch,
+				PollingInterval: "24h",           // prevent polling
+				TargetNamespace: targetNamespace, // to avoid conflicts with other tests
 			})
 			Expect(err).ToNot(HaveOccurred())
 		})