fix(pnpm): fallback from pnpm.cmd to pnpm on Windows for non-standard installs (#1606)

Author: terminalchai

src/package-managers/pnpm.ts

@@ -51,14 +51,37 @@ const npmConfigFromPnpmWorkspace = memoize(async (options: Options): Promise<Npm
   return config
 })
 
+/**
+ * Spawn pnpm. On Windows, prefer `pnpm.cmd` but fall back to `pnpm` when the
+ * `.cmd` shim is not available (e.g. mise, scoop).
+ */
+async function spawnPnpmCommand(
+  args: string[],
+  spawnPleaseOptions?: SpawnPleaseOptions,
+  spawnOptions?: SpawnOptions,
+) {
+  if (process.platform !== 'win32') {
+    return spawn('pnpm', args, spawnPleaseOptions, spawnOptions)
+  }
+
+  try {
+    return await spawn('pnpm.cmd', args, spawnPleaseOptions, spawnOptions)
+  } catch (e) {
+    if ((e as NodeJS.ErrnoException).code === 'ENOENT') {
+      return spawn('pnpm', args, spawnPleaseOptions, spawnOptions)
+    }
+
+    throw e
+  }
+}
+
 /** Fetches the list of all installed packages. */
 export const list = async (options: Options = {}): Promise<Index<string | undefined>> => {
   // use npm for local ls for completeness
   // this should never happen since list is only called in runGlobal -> getInstalledPackages
   if (!options.global) return npm.list(options)
 
-  const cmd = process.platform === 'win32' ? 'pnpm.cmd' : 'pnpm'
-  const { stdout } = await spawn(cmd, ['ls', '-g', '--json'])
+  const { stdout } = await spawnPnpmCommand(['ls', '-g', '--json'])
   const result = JSON.parse(stdout) as PnpmList
   const list = keyValueBy(result[0].dependencies || {}, (name, { version }) => ({
     [name]: version,
@@ -94,15 +117,13 @@ async function spawnPnpm(
   spawnOptions?: SpawnOptions,
   spawnPleaseOptions?: SpawnPleaseOptions,
 ): Promise<string> {
-  const cmd = process.platform === 'win32' ? 'pnpm.cmd' : 'pnpm'
-
   const fullArgs = [
     ...(npmOptions.global ? 'global' : []),
     ...(Array.isArray(args) ? args : [args]),
     ...(npmOptions.prefix ? `--prefix=${npmOptions.prefix}` : []),
   ]
 
-  const { stdout } = await spawn(cmd, fullArgs, spawnPleaseOptions, spawnOptions)
+  const { stdout } = await spawnPnpmCommand(fullArgs, spawnPleaseOptions, spawnOptions)
 
   return stdout
 }