Merge pull request #115 from joshuay03/raise-an-error-for-invalid-ranges

Raise an error when provided an invalid Range, or invalid :minimum and :maximum

Author: flavorjones

lib/rails/dom/testing/assertions/selector_assertions/html_selector.rb

@@ -131,6 +131,11 @@ def extract_equality_tests(refute)
                 else
                   comparisons[:minimum] ||= 1
                 end
+
+                if comparisons[:minimum] && comparisons[:maximum] && comparisons[:minimum] > comparisons[:maximum]
+                  raise ArgumentError, "Range begin or :minimum cannot be greater than Range end or :maximum"
+                end
+
                 comparisons
               end
           end

test/selector_assertions_test.rb

@@ -223,6 +223,20 @@ def test_assert_select_text_match
     end
   end
 
+  def test_assert_select_with_invalid_range
+    render_html "<div>foo</div>"
+    error = assert_raises(ArgumentError) { assert_select("div", 2..1) { nil } }
+    assert_equal "Range begin or :minimum cannot be greater than Range end or :maximum", error.message
+  end
+
+  def test_assert_select_with_invalid_minimum_and_maximum
+    render_html "<div>foo</div>"
+    error = assert_raises(ArgumentError) { assert_select("div", maximum: 0) { nil } }
+    assert_equal "Range begin or :minimum cannot be greater than Range end or :maximum", error.message
+    error = assert_raises(ArgumentError) { assert_select("div", minimum: 2, maximum: 1) { nil } }
+    assert_equal "Range begin or :minimum cannot be greater than Range end or :maximum", error.message
+  end
+
   #
   # Test assert_not_select.
   #