Skip to content

Conversation

@sethaxen
Copy link
Collaborator

Extends matmul methods to construct an AbstractDimArray whenever one argument is an AbstractDimArray and the other has DimUnitRange axes. Fixes #1122

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.53%. Comparing base (2e5a812) to head (8b08997).
⚠️ Report is 6 commits behind head on breaking.

Additional details and impacted files
@@             Coverage Diff              @@
##           breaking    #1124      +/-   ##
============================================
+ Coverage     82.43%   82.53%   +0.09%     
============================================
  Files            57       57              
  Lines          5647     5673      +26     
============================================
+ Hits           4655     4682      +27     
+ Misses          992      991       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sethaxen sethaxen marked this pull request as ready for review October 28, 2025 19:10
@sethaxen
Copy link
Collaborator Author

One coincidental behavior change is that before this PR dim(fill(1)) === nothing. After this PR dim(fill(1)) == (). Not certain if this has any bad side effects.

@tiemvanderdeure
Copy link
Collaborator

I guess there isn't really any answer to if fill(1) has dimensional axes

Maybe we can just add a dims(x::AbstractArray{<:Any, 0}) = nothing to not make this breaking

@rafaqz
Copy link
Owner

rafaqz commented Oct 29, 2025

Yeah lets special case it thats slightly undexpected.

Actually, fixing this will create ambiguities everywhere so we have to define dims twice for AbstractDimArray. Lets see if it causes any real problems first.

@rafaqz rafaqz merged commit c550ede into breaking Nov 8, 2025
9 of 10 checks passed
@rafaqz rafaqz deleted the linalg_axes_dim branch November 8, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants