-
Notifications
You must be signed in to change notification settings - Fork 52
Extend matmul with DimUnitRange axes #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## breaking #1124 +/- ##
============================================
+ Coverage 82.43% 82.53% +0.09%
============================================
Files 57 57
Lines 5647 5673 +26
============================================
+ Hits 4655 4682 +27
+ Misses 992 991 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
One coincidental behavior change is that before this PR |
|
I guess there isn't really any answer to if Maybe we can just add a |
|
Actually, fixing this will create ambiguities everywhere so we have to define |
Extends matmul methods to construct an
AbstractDimArraywhenever one argument is anAbstractDimArrayand the other hasDimUnitRangeaxes. Fixes #1122