-
Notifications
You must be signed in to change notification settings - Fork 52
use rebuild for similar of dimarray with new axes #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I might actually be more in favour of by default dropping metadata. Behaviour like this is a bit weird. But I don't know what the total consequences of a change like this would be |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## breaking #1082 +/- ##
=========================================
Coverage 86.29% 86.30%
=========================================
Files 56 56
Lines 5602 5606 +4
=========================================
+ Hits 4834 4838 +4
Misses 768 768 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm really not sure how not copying metadata plays out for Rasters.jl lets leave it for now until we have a more coherent overall metadata strategy.
|
Co-authored-by: Rafael Schouten <[email protected]>
Co-authored-by: Rafael Schouten <[email protected]>
It is really extensively tested - and had to make some changes so this change is tested as well |
|
I mean there is no test of what you changed here (I guess it's hard because in the case it's a DimArray either way - we probably need to use a test AbstractDimArray) |
closes #1077 (comment)
With new axes it never makes sense to keep refdims - since the axes might have new dimensions. For the metadata I've now opted to keep this since this is what happens for
similar(da, Int)- but then we could also choose to always drop metadata. I'm not sure