Skip to content

GSD > 0 #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cholmes merged 1 commit into from
Mar 30, 2021
Merged

GSD > 0 #1068

cholmes merged 1 commit into from
Mar 30, 2021

Conversation

@m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Mar 30, 2021

Related Issue(s): None (came up while writing a PR for #1067 )

Proposed Changes:

  1. Explicitly state that the gsd must be greater than 0. (Otherwise, explain what negative values mean.)

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr added this to the 1.0.0-rc.2 milestone Mar 30, 2021
@m-mohr m-mohr requested review from cholmes and matthewhanson March 30, 2021 15:20
@cholmes cholmes merged commit b2b1d7c into dev Mar 30, 2021
@cholmes cholmes deleted the gsd-gt0 branch March 30, 2021 16:07
@schwehr schwehr mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philvarner philvarner philvarner approved these changes

@cholmes cholmes cholmes approved these changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0-rc.2

Development

Successfully merging this pull request may close these issues.

4 participants

@m-mohr @philvarner @cholmes