Skip to content

Adjust to parser failures in r devel #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Adjust to parser failures in r devel #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b688f08
update pre-commit config
lorenzwalthert Mar 18, 2024
39a35ea
also upload results in GHA for R CMD check
IndrajeetPatil Mar 18, 2024
12c88a4
check with newer error message
IndrajeetPatil Mar 21, 2024
89ea11a
cover older versions as well
IndrajeetPatil Mar 21, 2024
8d70633
undo unrelated upload
lorenzwalthert Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ default_language_version:

repos:
- repo: https://github.com/lorenzwalthert/precommit
rev: v0.3.2.9027
rev: v0.4.0
hooks:
- id: style-files
args:
Expand Down Expand Up @@ -101,7 +101,7 @@ repos:
)$
- id: pkgdown
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
rev: v4.5.0
hooks:
- id: check-added-large-files
args: ["--maxkb=200"]
Expand All @@ -119,7 +119,7 @@ repos:
tests/testthat/_snaps/.*|
)$
- repo: https://github.com/lorenzwalthert/gitignore-tidy
rev: 475bf5d96927a1887ce2863ff3075b1d7240bc51
rev: 517cddbf1d8514ddaf43159686617ae65895dc99
hooks:
- id: tidy-gitignore
- repo: local
Expand Down
3 changes: 2 additions & 1 deletion tests/testthat/test-parsing.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ test_that("CRLF EOLs fail with informative error", {


test_that("mixed CRLF / LF EOLs fail", {
error_msg_stem <- if (getRversion() < "4.4") "unexpected input" else "unexpected invalid token"
expect_error(
style_text("a + 3 -4 -> x\nx + 2\r\n glück + 1"),
"unexpected input"
error_msg_stem
)
})

Expand Down