added ability to pass down url query parameters to initial oauth2.0 authorization page#503
added ability to pass down url query parameters to initial oauth2.0 authorization page#503hadley merged 31 commits intor-lib:masterfrom
Conversation
…sed argument error
…st and accidentally wrapping the brackets in wrong place
… in token2.0 'sign' function should have been self$params$auth_page_query_params if actually needed
…ult to list() not NULL
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
Can you please do a pass over your changes with styler, or by manually following the rules at http://style.tidyverse.org/? It's currently rather hard for me to read the code.
# Conflicts: # man/init_oauth2.0.Rd # man/oauth2.0_token.Rd
fixing styler overreach
|
Done - used 'styler' and tweaked manually when it didn't work so well. Let me know if it needs further tweaking. |
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
I think the idea is sound. I've made a bunch of suggestions to improve the style.
|
Done. |
|
Done. Replaced the empty input test with something that's hopefully clearer, more concise and more useful. |
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
Looks great. One last thing: can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).
|
Done - let me know if it's too wordy (or should be split up into more bullets). |
|
Thanks! |
|
My pleasure - thanks for the all the help & guidance with this. :) |
|
Hey @cosmomeese, you might like to know this feature comes in handy for Google OAuth flow too. We can pass the user's email address as a hint to the auth server, which pre-selects the targeted identity in the consent screen: |
|
That's so great @jennybc! Thanks for letting me know - it's always nice to see one's work end up being useful to someone else :) |
3 participants
added ability pass down url query parameters to the initial oauth2.0 authorization page. e.g. this is useful for the Fitbit API which defines additional URI parameters (such as token expiration duration, ability to force authorization page/consent and others - see Authorization Page @ https://dev.fitbit.com/build/reference/web-api/oauth2/) that must be appended to the initial authorization URL.