-
Notifications
You must be signed in to change notification settings - Fork 148
refactor(auto-api.ts): chatgpt o1 cleanup #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
commit: |
TheMcnafaha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think gpt knows node better than me lol. It did make some interesting decisions regarding some of the regex, but if you're short on time I think you can just merge the file as it. It's a net improvement anyways.
|
Took your comments into account. Thanks for the review 🙇♂️ . I think the regex is good for windows. But if it's problematic feel free to re-change in another PR :) |
What is it?
Why is it needed?
Checklist:
pnpm changeand documented my changes