Skip to content

Conversation

@maiieul
Copy link
Contributor

@maiieul maiieul commented Oct 10, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

•	Variable Renaming: Changed variable names like lol to capture and hacky to exportedApi for better readability.
•	Regex Enhancements: Updated regex patterns to be platform-independent by matching both / and \ using [\\/].
•	Edge Case Handling: Added checks to prevent accessing undefined variables when arrays may be empty.
•	Error Logging: Included error logging in the catch block of writeToDocs to output any errors during file writing.
•	Path Handling: Used path.resolve to handle file paths in a platform-independent way.
•	Comment Trimming: Trimmed comments to remove unnecessary whitespace.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: 691a11b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maiieul maiieul requested a review from TheMcnafaha October 10, 2024 18:12
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 10, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/qwikifiers/qwik-ui@985
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@985
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@985
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@985

commit: 691a11b

Copy link
Member

@TheMcnafaha TheMcnafaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think gpt knows node better than me lol. It did make some interesting decisions regarding some of the regex, but if you're short on time I think you can just merge the file as it. It's a net improvement anyways.

@maiieul
Copy link
Contributor Author

maiieul commented Oct 15, 2024

Took your comments into account. Thanks for the review 🙇‍♂️ . I think the regex is good for windows. But if it's problematic feel free to re-change in another PR :)

@maiieul maiieul merged commit 23c6676 into qwikifiers:main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants