Add toggle and togglegroup headless and styled components #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5fa12fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
steffanek
force-pushed
the
pr-toggle-togglegroup
branch
from
f226c46 to
892cde3
Compare
commit: |
Collaborator
|
I noticed that when there is not a pressed toggle, then the tab order skips the entire component. Is that the intended behavior? Intuitively my thoughts were it would focus the first focusable toggle button. I think this could be a good test 😄 Here's a preview: toggle-group-tab-focus.mp4 |
thejackshelton
requested changes
Sep 4, 2024
apps/website/src/routes/docs/headless/toggle-group/examples/defaultValue.tsx
Outdated
Show resolved
Hide resolved
apps/website/src/routes/docs/headless/toggle-group/examples/defaultValue.tsx
Show resolved
Hide resolved
apps/website/src/routes/docs/headless/toggle-group/examples/test-value-bind-multiple.tsx
Show resolved
Hide resolved
thejackshelton-kunaico
requested changes
Sep 11, 2024
steffanek
force-pushed
the
pr-toggle-togglegroup
branch
from
e6bd6fb to
5fa12fd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Why is it needed?
Those components were missing.
Checklist:
pnpm changeand documented my changes