Skip to content

Carousel #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 89 commits into from
Jul 30, 2024
Merged

Carousel #894

merged 89 commits into from
Jul 30, 2024

Conversation

@thejackshelton
Copy link
Collaborator

@thejackshelton thejackshelton commented Jul 21, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

@thejackshelton
refactor: setup initial carousel testsw
cbecafd
@thejackshelton
fix: carousel in CSR
13f2862
@thejackshelton
add expectation
7650e97
@thejackshelton
test: added test cases
8248ff8
@thejackshelton
test: some additional test cases
f1d02fb
@thejackshelton
not draggable
5a65216
@thejackshelton
CSS scroll snapping on mobile
7308a7c
@thejackshelton
threshold tests
aa2785d
@thejackshelton
try simpler code refactor
f03f0c8
@thejackshelton
small docs
49dc6b8
@thejackshelton
Merge branch 'main' of https://github.com/qwikifiers/qwik-ui into imp…
ef6f282 
…roved-carousel
@thejackshelton
grab index from inline
44fafed
@thejackshelton
improved examples
066480a
@thejackshelton
use scorllLeft instead
e2090ec
@thejackshelton
hacky impl
282d572
@thejackshelton
fix: slide snapping
585ad61
@thejackshelton
better naming
c81fbfe
@thejackshelton
much simpler carousel
70f115a
@thejackshelton
fix: get proper array order
ae05887
@thejackshelton
account for slide margin
5d38c29
@thejackshelton
updated correct index
edf7515
@thejackshelton
update with css scroll snapping
a65ce11
@thejackshelton
simplify container
57a5f24
@thejackshelton
get buttons working again
6152865
@thejackshelton
setup for drag to do its own behavior
9b94d5d
@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 43f7055

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@qwik-ui/headless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 21, 2024 •
edited
Loading

commit: 43f7055

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@894

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@894

npm i https://pkg.pr.new/qwikifiers/qwik-ui@894

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@894

Open in Stackblitz •

thejackshelton and others added 28 commits July 25, 2024 15:54
@thejackshelton
initial working autoplay
d1dfa92
@thejackshelton
bound signals
da3055d
@thejackshelton
simplify bound signal
6918bd5
@thejackshelton
improved autoplay and tabs aria
a5ac510
@thejackshelton
add in aria-selected
3073ded
@thejackshelton
accessible name for autoplay player button
07f0fcf
@thejackshelton
respecting reduced motion
355ab54
@thejackshelton
autoplay looping working
357867c
@thejackshelton
Merge branch 'main' into carousel-mode
4564114
@thejackshelton
improved experience when consuming and also support for updating flex…
93ce9d7 
…-basis automatically when slides per view change
@thejackshelton
setup for the initial index
e578938
@thejackshelton
more test cases
279a86e
@thejackshelton
multiple slides working on the server
d364dc5
@thejackshelton
proper gap
c144692
@thejackshelton
add correct initial index
6d9a0a9
@thejackshelton
get initial indexes sort of working
d1ac93a
@thejackshelton
correct snapping again on mobile with initial index
fa5065c
@thejackshelton
almost
5458e33
@thejackshelton
next and prev buttons should work
7438e31
@thejackshelton
improved styling
50e7fd3
@thejackshelton
upgrade to 1.7.2
437cc7b
@thejackshelton
no caret
a45316f
@thejackshelton
add in caret only in root
7859012
@thejackshelton
latest from main
d43231e
@thejackshelton
initial working
c7b5bb2
@thejackshelton
initial working in all snap modes
b66a4fb
@thejackshelton
carousel docs
a9aefee
@thejackshelton
add in changeset
43f7055
@thejackshelton thejackshelton merged commit ff7fade into qwikifiers:main Jul 30, 2024
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thejackshelton