fix(bump qwik dep version): bump qwik peer dep in packages #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- since packages were depending on a lower version they still exhibited the TS4023 error - using the latest qwik version resolves that fix qwikifiers#396
Contributor
Author
|
@shairez, I noticed that the d.ts files are still missing (some of them) in the latest release. Specifically the autocomplete ones mentioned in #396 . It turns out the packages having a peer dependency is reflected in what version pnpm makes available to them. This fix seems to take care of that as well as ensure the dts errors are still surfaced - the |
Contributor
Author
|
@shairez gentle reminder for the above |
Contributor
|
Thanks for the fix @gparlakov ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #396
What is it?
Use cases and why
To successfully generate the missing d.ts files (as per the bug #396)
Checklist: