feat(Query for Author): If passed Author id query Author API#78
Merged
feat(Query for Author): If passed Author id query Author API#78
Conversation
iamgarima
reviewed
Apr 5, 2019
| const collectionId = get(this.props, ["collectionId"],null); | ||
|
|
||
| const url = (collectionType && collectionId) ? | ||
| `/api/v1/${collectionType}/${collectionId}/collection`: |
Contributor
There was a problem hiding this comment.
Is this /api/v1/authors/<author_id>/collection a collection api?
Contributor
There was a problem hiding this comment.
Can we use api prop in LoadMoreStoriesBase for it?
sinujohn91
suggested changes
Apr 5, 2019
| const collectionId = get(this.props, ["collectionId"],null); | ||
|
|
||
| const url = (collectionType && collectionId) ? | ||
| `/api/v1/${collectionType}/${collectionId}/collection`: |
Contributor
There was a problem hiding this comment.
Its not collectionId, its authorId. I guess passing authorId and checking that, instead of passing collectionType should suffice.
Contributor
|
please update the readme as well |
chchitti
changed the title
chchitti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed because we need author stories for vikatan. The urls format is /api/v1/authors/<author_id>/collection.
So I have made a provision to accept a type of collection and collection id and stories will be returned based on these inputs.