fix(table story element): fix breaking table story element#76
Merged
sinujohn91 merged 1 commit intomasterfrom Mar 28, 2019
Merged
fix(table story element): fix breaking table story element#76sinujohn91 merged 1 commit intomasterfrom
sinujohn91 merged 1 commit intomasterfrom
Conversation
asimqt
reviewed
Mar 28, 2019
| render() { | ||
| const tableModData = this.state; | ||
| const tableModData = this.state.tableModData; | ||
| if (!get(tableModData, ['headerFields'], []).length > 0) { |
Contributor
There was a problem hiding this comment.
I think we could have remove tableModData altogether if it doesn't add any value
Athira001
approved these changes
Mar 28, 2019
asimqt
approved these changes
Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regression came while a refactor was done to remove lodash.