Skip to content

Bugfix hero image#183

Merged
ags1773 merged 5 commits intomasterfrom
bugfix-hero-image
May 19, 2021
Merged

Bugfix hero image#183
ags1773 merged 5 commits intomasterfrom
bugfix-hero-image

Conversation

@ags1773
Copy link
Contributor

@ags1773 ags1773 commented May 19, 2021

Fixes error TypeError: Cannot read property 'hero-image-s3-key' of null when a story without hero image is passed to responsive hero image

It's a part of https://github.com/quintype/ace-planning/issues/359

@@ -4,7 +4,10 @@ import omit from "@babel/runtime/helpers/objectWithoutProperties";
import get from "lodash/get";
Copy link
Contributor Author

@ags1773 ags1773 May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file and its tests is the only legitimate code change. Everything else is linting

@ags1773 ags1773 requested a review from ReenaSingh07 May 19, 2021 09:59
@ags1773 ags1773 merged commit 4fd5aa4 into master May 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix-hero-image branch May 19, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants