Skip to content

Conversation

@yrodiere
Copy link
Member

@yrodiere yrodiere commented Jun 12, 2025

This fixes issues we've been seeing in Jakarta Data when using Quarkus. Here, for example: quarkusio/quarkus-quickstarts#1544 (comment)
The upstream fix is there: hibernate/hibernate-orm#10314

This also adds a non-regression test.

Opening as draft because we need a Hibernate ORM release. => 7.0.2.Final was released

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 12, 2025

/cc @gsmet (hibernate-orm)

@yrodiere yrodiere marked this pull request as ready for review June 12, 2025 15:30
@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 12, 2025
@yrodiere yrodiere force-pushed the jakarta-data-unwrap branch from eaccb76 to 974b1d1 Compare June 12, 2025 15:30
yrodiere added 3 commits June 13, 2025 09:44
So that Hibernate Data Repositories can work correctly.
It's been failing in quickstarts.
@yrodiere yrodiere force-pushed the jakarta-data-unwrap branch from 974b1d1 to 5c20509 Compare June 13, 2025 07:44
@yrodiere yrodiere merged commit 3060ddd into quarkusio:main Jun 13, 2025
56 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 13, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 13, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 13, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5c20509.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_UniFailed - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:236)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_UniFailed(MicrometerTimedInterceptorTest.java:202)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:435)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hibernate-orm Hibernate ORM dependencies Pull requests that update a dependency file kind/bugfix triage/flaky-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants