Skip to content

Conversation

@yrodiere
Copy link
Member

@yrodiere yrodiere commented Mar 6, 2023

Follows up on #31540

Those tests weren't added to .github/native-tests.json so they weren't
executed, but in any case we don't need then since we don't expect this
feature to work any differently in native mode.
@quarkus-bot quarkus-bot bot added area/core area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE labels Mar 6, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 6, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm)

@quarkus-bot

This comment has been minimized.

yrodiere added 2 commits March 6, 2023 15:58
* Move it to the "Database related configuration" section
* Make sure that enum values are rendered correctly
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 6, 2023

Failing Jobs - Building a5aa4b6

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs
✔️ Gradle Tests - JDK 11 Windows
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.AddExtensionToModuleInMultiModuleKtsProjectTest.testBasicMultiModuleBuild line 35 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment 
! Skipped: extensions/avro/deployment extensions/csrf-reactive/deployment extensions/grpc/deployment and 140 more

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

io.quarkus.resteasy.reactive.server.test.CloserTest.test line 62 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

@yrodiere
Copy link
Member Author

yrodiere commented Mar 7, 2023

I saw the Gradle Tests failure in another, unrelated PR (#31632) so it's just a flaky test.

io.quarkus.resteasy.reactive.server.test.CloserTest doesn't use Hibernate ORM so it seems unrelated as well.

@yrodiere yrodiere removed the request for review from Sanne March 7, 2023 10:13
@yrodiere
Copy link
Member Author

yrodiere commented Mar 7, 2023

Merging, thanks!

@yrodiere yrodiere merged commit 8e7ca48 into quarkusio:main Mar 7, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 7, 2023
@yrodiere yrodiere deleted the i31475-cleanup branch August 7, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants