-
Notifications
You must be signed in to change notification settings - Fork 4
Generate Flow bean from Workflow file #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89986ce to
89945fc
Compare
Member
ricardozanini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, I'll take a better look early next week.
core/deployment/src/main/java/io/quarkiverse/flow/deployment/WorkflowNamingConverter.java
Outdated
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkiverse/flow/config/FlowDefinitionsConfig.java
Outdated
Show resolved
Hide resolved
Member
|
@mcruzdev can you rebase? 😬 |
ricardozanini
approved these changes
Nov 24, 2025
Member
|
@fjtirado mind also taking a look? |
mcruzdev
commented
Nov 24, 2025
core/deployment/src/main/java/io/quarkiverse/flow/deployment/WorkflowNamingConverter.java
Outdated
Show resolved
Hide resolved
ricardozanini
approved these changes
Nov 25, 2025
core/runtime/src/main/java/io/quarkiverse/flow/config/FlowDefinitionsConfig.java
Outdated
Show resolved
Hide resolved
ricardozanini
requested changes
Nov 25, 2025
...eployment/src/test/java/io/quarkiverse/flow/deployment/test/WorkflowNamingConverterTest.java
Outdated
Show resolved
Hide resolved
mcruzdev
commented
Nov 25, 2025
core/runtime/src/main/java/io/quarkiverse/flow/config/FlowDefinitionsConfig.java
Outdated
Show resolved
Hide resolved
...eployment/src/test/java/io/quarkiverse/flow/deployment/test/WorkflowNamingConverterTest.java
Outdated
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkiverse/flow/config/FlowDefinitionsConfig.java
Outdated
Show resolved
Hide resolved
ricardozanini
approved these changes
Nov 26, 2025
core/deployment/src/main/java/io/quarkiverse/flow/deployment/WorkflowNamingConverter.java
Outdated
Show resolved
Hide resolved
Member
|
@mcruzdev can you rebase? |
fjtirado
reviewed
Nov 27, 2025
...deployment/src/main/java/io/quarkiverse/flow/deployment/DiscoveredWorkflowFileBuildItem.java
Show resolved
Hide resolved
Signed-off-by: Matheus Cruz <[email protected]>
Signed-off-by: Matheus Cruz <[email protected]>
|
🙈 The PR is closed and the preview is expired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WorkflowDefinitionorFlowclass.FlowIdentifierBuildItemFloworWorkflowDefinitionbeans:quarkus.flow.definitions.namespaceCloses #87