Refactor fastrpc_log lifecycle and improve runtime logging #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize and deinitialize fastrpc_log during domain lifecycle instead of global init/deinit. Refactor HAP_debug_runtime for clarity and efficiency by adding early return when no logging is required, consolidating buffer allocation and message formatting, validating length, and ensuring deterministic cleanup. The changes also streamline logging logic by handling persist buffer for critical logs, enabling file logging only when configured, and invoking HAP_debug based on log mask, while reducing unnecessary heap allocations and improving control flow. Signed-off-by: Vinayak Katoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize and deinitialize fastrpc_log during domain lifecycle instead of global init/deinit.
Refactor HAP_debug_runtime for clarity and efficiency by adding early return when no logging is required, consolidating buffer allocation and message formatting, validating length, and ensuring deterministic cleanup. The changes also streamline logging logic by handling persist buffer for critical logs, enabling file logging only when configured, and invoking HAP_debug based on log mask, while reducing unnecessary heap allocations and improving control flow.