cleanup: remove stale async fastrpc code (#218) #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekanshibu
reviewed
Aug 27, 2025
Jianping-Li
force-pushed
the
issue-218-fix
branch
from
c5f37c2 to
f4bfa60
Compare
Jianping-Li
force-pushed
the
issue-218-fix
branch
from
f4bfa60 to
9981318
Compare
Contributor
|
can you please resolve the merge conflict here? |
Removed async-related fastrpc code. It is stale code that is no longer used or maintained. Signed-off-by: Jianping Li <[email protected]>
Jianping-Li
force-pushed
the
issue-218-fix
branch
from
9981318 to
50fa9cf
Compare
ekanshibu
approved these changes
Sep 11, 2025
|
This pull request has been marked as stale due to 60 days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #218 by removing unused and outdated async fastRPC code from the fastrpc module.
Changes include:
This cleanup improves maintainability and aligns with the current usage patterns of fastRPC.
Fixes #218.