Remove fallback to default device open #210
Conversation
|
Can you also clean-up the following:
|
| return name; | ||
| } | ||
|
|
||
| static const char *get_default_device_name(int domain_id) { |
There was a problem hiding this comment.
okay, I checked and this function cannot be removed. The reason is that some old platform use non-secure devices for daemons(if non-secure-domain property is added in DT).
You can just rename the function as get_non_secure_device_name and modify the default: case here.
| static int fastrpc_wait_for_device(int domain) | ||
| { | ||
| int inotify_fd = -1, watch_fd = -1, err = 0; | ||
| const char *sec_dev_name = NULL, *def_dev_name = NULL; |
There was a problem hiding this comment.
check for non-secure device also to maintain backward compatibility
quic-lxu5
force-pushed
the
fallback
branch
2 times, most recently
from
5f86fc5 to
867b001
Compare
In case of default domain ID, the device open request falls back to DEFAUL_DEVICE which will be defined in the libs to which the application is linked. Remove this legacy fallback logic to avoid any confusion and unexpected observations. Signed-off-by: Ling Xu <[email protected]>
|
This pull request has been marked as stale due to 60 days of inactivity. |
2 participants
In case of default domain ID, the device open request falls back to DEFAUL_DEVICE which will be defined in the libs to which the application is linked. Remove this legacy fallback logic to avoid any confusion and unexpected observations.