Remove ro.debuggable android definition and enable critical logs

for all build types.

Signed-off-by: Vinayak Katoch <[email protected]>

Author: Vinayak Katoch

inc/fastrpc_common.h

@@ -126,7 +126,6 @@
 	 FASTRPC_ENABLE_SYSTRACE = 6, //to enable tracing using Systrace
 	 FASTRPC_DEBUG_PDDUMP = 7, // to enable pd dump debug data collection on rooted device for signed/unsigned pd
 	 FASTRPC_PROCESS_ATTRS_PERSISTENT = 8, // to set proc attr as persistent
-	 FASTRPC_BUILD_TYPE = 9 // Fetch build type of firmware image. It gives the details if its debug or prod build
  }fastrpc_properties;
 
 /**

src/fastrpc_apps_user.c

@@ -228,8 +228,7 @@ const char *ENV_DEBUG_VAR_NAME[] = {"FASTRPC_PROCESS_ATTRS",
                                     "FASTRPC_PERF_FREQ",
                                     "FASTRPC_DEBUG_SYSTRACE",
                                     "FASTRPC_DEBUG_PDDUMP",
-                                    "FASTRPC_PROCESS_ATTRS_PERSISTENT",
-                                    "ro.debuggable"};
+                                    "FASTRPC_PROCESS_ATTRS_PERSISTENT"};
 
 const char *SUBSYSTEM_NAME[] = {"adsp", "mdsp", "sdsp", "cdsp", "cdsp1", "reserved", "reserved", "reserved"};
 

src/fastrpc_log.c

@@ -1,15 +1,13 @@
 // Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved.
 // SPDX-License-Identifier: BSD-3-Clause
 
-#define _GNU_SOURCE
 #include <pthread.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/time.h>
 #include <limits.h>
-#include <unistd.h>
 
 #include "AEEStdErr.h"
 #include "fastrpc_config.h"
@@ -279,28 +277,14 @@ void HAP_debug(const char *msg, int level, const char *filename, int line) {
 }
 
 void fastrpc_log_init() {
-  bool debug_build_type = false;
   int nErr = AEE_SUCCESS, fd = -1;
   char build_type[PROPERTY_VALUE_MAX];
   char *logfilename;
 
   pthread_mutex_init(&persist_buf.mut, 0);
   pthread_mutex_lock(&persist_buf.mut);
-  /*
-   * Get build type by reading the target properties,
-   * if buuid type is eng or userdebug allocate 1 MB persist buf.
-   */
-  if (fastrpc_get_property_string(FASTRPC_BUILD_TYPE, build_type, NULL)) {
-#if !defined(LE_ENABLE)
-    if (!strncmp(build_type, "eng", PROPERTY_VALUE_MAX) ||
-        !strncmp(build_type, "userdebug", PROPERTY_VALUE_MAX))
-      debug_build_type = true;
-#else
-    if (atoi(build_type))
-      debug_build_type = true;
-#endif
-  }
-  if (persist_buf.buf == NULL && debug_build_type) {
+
+  if (persist_buf.buf == NULL) {
     /* Create a debug buffer to append DEBUG FARF level message. */
     persist_buf.buf = (char *)rpcmem_alloc_internal(
         RPCMEM_HEAP_ID_SYSTEM, RPCMEM_DEFAULT_FLAGS | RPCMEM_TRY_MAP_STATIC,