Remove ro.debuggable and enable critical logs for all builds

Removed ro.debuggable property and enabled critical logs across
all build types.

Signed-off-by: Vinayak Katoch <[email protected]>

Author: quic-vkatoch

inc/fastrpc_common.h

@@ -126,7 +126,6 @@
 	 FASTRPC_ENABLE_SYSTRACE = 6, //to enable tracing using Systrace
 	 FASTRPC_DEBUG_PDDUMP = 7, // to enable pd dump debug data collection on rooted device for signed/unsigned pd
 	 FASTRPC_PROCESS_ATTRS_PERSISTENT = 8, // to set proc attr as persistent
-	 FASTRPC_BUILD_TYPE = 9 // Fetch build type of firmware image. It gives the details if its debug or prod build
  }fastrpc_properties;
 
 /**

src/fastrpc_apps_user.c

@@ -225,8 +225,7 @@ const char *ENV_DEBUG_VAR_NAME[] = {"FASTRPC_PROCESS_ATTRS",
                                     "FASTRPC_PERF_FREQ",
                                     "FASTRPC_DEBUG_SYSTRACE",
                                     "FASTRPC_DEBUG_PDDUMP",
-                                    "FASTRPC_PROCESS_ATTRS_PERSISTENT",
-                                    "ro.debuggable"};
+                                    "FASTRPC_PROCESS_ATTRS_PERSISTENT"};
 
 const char *SUBSYSTEM_NAME[] = {"adsp", "mdsp", "sdsp", "cdsp", "cdsp1", "gdsp0", "gdsp1", "reserved"};
 
@@ -3141,6 +3140,7 @@ static void domain_deinit(int domain) {
     trace_marker_deinit(domain);
     deinitFileWatcher(domain);
     adspmsgd_stop(domain);
+    fastrpc_log_deinit();
     fastrpc_mem_close(domain);
     apps_mem_deinit(domain);
     hlist[domain].state = 0;
@@ -3900,7 +3900,7 @@ static int domain_init(int domain, int *dev) {
   }
   VERIFY(AEE_SUCCESS == (nErr = fastrpc_mem_open(domain)));
   VERIFY(AEE_SUCCESS == (nErr = apps_mem_init(domain)));
-
+  fastrpc_log_init();
   if (dom == CDSP_DOMAIN_ID || dom == CDSP1_DOMAIN_ID || dom == GDSP0_DOMAIN_ID || dom == GDSP1_DOMAIN_ID) {
     panic_handle = get_adsp_current_process1_handle(domain);
     if (panic_handle != INVALID_HANDLE) {
@@ -4011,7 +4011,6 @@ static void fastrpc_apps_user_deinit(void) {
   fastrpc_notif_deinit();
   apps_mem_table_deinit();
   fastrpc_wake_lock_deinit();
-  fastrpc_log_deinit();
   fastrpc_mem_deinit();
   PL_DEINIT(apps_std);
   PL_DEINIT(rpcmem);
@@ -4073,7 +4072,6 @@ static int fastrpc_apps_user_init(void) {
   VERIFY(AEE_SUCCESS == (nErr = PL_INIT(rpcmem)));
   fastrpc_mem_init();
   fastrpc_context_table_init();
-  fastrpc_log_init();
   fastrpc_config_init();
   pthread_mutex_init(&update_notif_list_mut, 0);
   VERIFYC(NULL != (hlist = calloc(NUM_DOMAINS_EXTEND, sizeof(*hlist))),

src/fastrpc_log.c

@@ -162,44 +162,59 @@ void HAP_debug_runtime(int level, const char *file, int line,
                        const char *format, ...) {
   int len = 0;
   va_list argp;
-  char *buf = NULL, *log = NULL;
-
-  /*
-   * Adding logs to persist buffer when level is set to
-   * RUNTIME_RPC_CRITICAL and fastrpc_log mask is disabled.
-   */
-  if (((1 << level) & (fastrpc_logmask)) ||
-      ((level == HAP_LEVEL_RPC_CRITICAL) && persist_buf.buf) ||
-      log_userspace_file_fd != NULL) {
-    buf = (char *)malloc(sizeof(char) * MAX_FARF_LEN);
-    if (buf == NULL) {
-      return;
-    }
-    va_start(argp, format);
-    len = vsnprintf(buf, MAX_FARF_LEN, format, argp);
-    va_end(argp);
-    log = (char *)malloc(sizeof(char) * MAX_FARF_LEN);
-    if (log == NULL) {
-      return;
-    }
-    snprintf(log, MAX_FARF_LEN, "%d:%d:%s:%s:%d: %s", getpid(), gettid(),
-             __progname, file, line, buf);
+  char *buf = NULL;
+  const uint32_t level_mask = (1 << level);
+  const bool log_enabled = (level_mask & fastrpc_logmask);
+  const bool is_critical = (level == HAP_LEVEL_RPC_CRITICAL);
+  const bool need_persist = is_critical && persist_buf.buf;
+  const bool need_file_log = (log_userspace_file_fd != NULL);
+
+  /* Early return if no logging is needed */
+  if (!log_enabled && !need_persist && !need_file_log) {
+    return;
   }
 
-  print_dbgbuf_data(log, len);
-  if (((1 << level) & (fastrpc_logmask))) {
-    if (log_userspace_file_fd != NULL) {
-      fputs(log, log_userspace_file_fd);
-      fputs("\n", log_userspace_file_fd);
-    }
-    HAP_debug(buf, level, file, line);
+  /* Allocate buffer only when needed */
+  buf = (char *)malloc(sizeof(char) * MAX_FARF_LEN);
+  if (buf == NULL) {
+    return;
   }
-  if (buf) {
+
+  /* Format the message once */
+  va_start(argp, format);
+  len = vsnprintf(buf, MAX_FARF_LEN, format, argp);
+  va_end(argp);
+
+  /* Validate length */
+  if (len <= 0 || len >= MAX_FARF_LEN) {
     free(buf);
+    return;
   }
-  if (log) {
-    free(log);
+
+  /* Handle persist buffer for critical logs */
+  if (need_persist || (log_enabled && IS_PERSIST_BUF_DATA(len, level))) {
+    print_dbgbuf_data(buf, len);
   }
+
+  /* Handle regular logging when enabled */
+  if (log_enabled) {
+    /* File logging */
+    if (need_file_log) {
+      char *filelog = (char *)malloc(sizeof(char) * MAX_FARF_LEN);
+      if (filelog) {
+        if (snprintf(filelog, MAX_FARF_LEN, "%d:%d:%s:%s:%d: %s", 
+                     getpid(), gettid(), __progname, file, line, buf) > 0) {
+          fputs(filelog, log_userspace_file_fd);
+          fputs("\n", log_userspace_file_fd);
+        }
+        free(filelog);
+      }
+    }
+    /* Debug output */
+    HAP_debug(buf, level, file, line);
+  }
+
+  free(buf);
 }
 
 #ifdef __LE_TVM__
@@ -279,28 +294,14 @@ void HAP_debug(const char *msg, int level, const char *filename, int line) {
 }
 
 void fastrpc_log_init() {
-  bool debug_build_type = false;
   int nErr = AEE_SUCCESS, fd = -1;
   char build_type[PROPERTY_VALUE_MAX];
   char *logfilename;
 
   pthread_mutex_init(&persist_buf.mut, 0);
   pthread_mutex_lock(&persist_buf.mut);
-  /*
-   * Get build type by reading the target properties,
-   * if buuid type is eng or userdebug allocate 1 MB persist buf.
-   */
-  if (fastrpc_get_property_string(FASTRPC_BUILD_TYPE, build_type, NULL)) {
-#if !defined(LE_ENABLE)
-    if (!strncmp(build_type, "eng", PROPERTY_VALUE_MAX) ||
-        !strncmp(build_type, "userdebug", PROPERTY_VALUE_MAX))
-      debug_build_type = true;
-#else
-    if (atoi(build_type))
-      debug_build_type = true;
-#endif
-  }
-  if (persist_buf.buf == NULL && debug_build_type) {
+
+  if (persist_buf.buf == NULL) {
     /* Create a debug buffer to append DEBUG FARF level message. */
     persist_buf.buf = (char *)rpcmem_alloc_internal(
         RPCMEM_HEAP_ID_SYSTEM, RPCMEM_DEFAULT_FLAGS | RPCMEM_TRY_MAP_STATIC,